Add Gaussian OpenPulse waveform generator with PyQASM module export#77
Merged
TheGupta2012 merged 6 commits intomainfrom Feb 2, 2026
Merged
Add Gaussian OpenPulse waveform generator with PyQASM module export#77TheGupta2012 merged 6 commits intomainfrom
TheGupta2012 merged 6 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
TheGupta2012
left a comment
There was a problem hiding this comment.
Hi @robertjovanov , this is a great start! I have given some comments but the overall structure looks good to me!
It'll be good if you can add some tests as well for the functionality
…neration, overrides, and unrolling.
… as a building block for larger experiments, such as Qubit Spectroscopy
Collaborator
Author
|
Hi @TheGupta2012 , thanks a lot for the feedback. I tried to implement most of it. I also included unit tests, as well as a Jupyter notebook demonstrating how to use the module on its own, and in larger experiments. |
Member
TheGupta2012
left a comment
There was a problem hiding this comment.
Hi @robertjovanov , thank you for incorporating the review! Changes look good to me, just one comment about the tests. Should be good to merge post that
TheGupta2012
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a foundational OpenPulse waveform generator to qbraid-algorithms.
The contribution implements a reusable Gaussian OpenPulse waveform generator, exported as a PyQASM module, and is intended as a base for future pulse-level extensions.