[pre-commit.ci] pre-commit autoupdate#733
Open
pre-commit-ci[bot] wants to merge 2 commits into
Open
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.15.15 → v0.15.20](astral-sh/ruff-pre-commit@v0.15.15...v0.15.20)
Member
|
@pytroll/core I need to remove Python 3.11 support to make mypy happy in pre-commit. The problem seems to be that mypy is forcing 3.11 syntax checking, but pre-commit is installing in a Python 3.14 environment, getting a 3.14-compatible version of numpy, and that numpy is using typing syntax that isn't supported in Python 3.11. We could force pre-commit to use an older version of Python (3.11), but then anyone running pre-commit also has to be using that version of Python. Any issues with a separate PR removing Python 3.11 support? |
Member
|
Go ahead. πthon (Python 3.14) is already stable and we typically support only three latest versions anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: