[Feature] Report MicroDuck trajectory evaluation metrics - #4396
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4396
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vmoens
added this pull request to stack #4430
September 18, 2026 06:35
vmoens
force-pushed
the
codex/microduck-evaluation-metrics
branch
from
September 18, 2026 12:53
22bfe2d to
fd644bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes complete-trajectory evaluation a MicroDuck environment API instead of implementing environment semantics inside the PPO recipe.
MicroDuckEnv.trajectory_metrics, which owns the observation layout anddiagnostic_*key interpretation.examples/microduck/ppo_mujoco.pyrelative tomain; the evaluator now binds the metric callback in one line.What was wrong and what is fixed
The recipe previously contained more than one hundred lines that decoded MicroDuck-specific observation indices and diagnostic keys. Besides obscuring the PPO example, this made the environment contract look like application boilerplate:
Padding also cannot be replaced with zero when computing extrema. For example, every observed height may be negative:
The same complete-trajectory mask is used for rates, means, and paired-step events.
Tests
test_microduck_trajectory_metrics_exclude_paddingtest_microduck_example_recurrent_ppo_trains_on_whole_episodesBoth pass locally. The focused regression covers padded garbage, negative valid maxima, wrapped headings, world-ground velocity, and a one-step trajectory.