Skip to content

[BugFix] Preserve sampler state across repeated checkpoints - #4388

Open
vmoens wants to merge 1 commit into
mainfrom
codex/replay-sampler-checkpoint-restore
Open

vmoens wants to merge 1 commit into
mainfrom
codex/replay-sampler-checkpoint-restore

Conversation

@vmoens

@vmoens vmoens commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Fix SamplerWithoutReplacement checkpoint restoration so scalar fields are restored as Python values instead of remaining tied to memory-mapped checkpoint tensors. This lets a resumed replay buffer be checkpointed again at a new path.

Tests: test/rb/test_samplers.py::TestSamplers::test_sampler_without_rep_dumps_loads.

@pytorch-bot

pytorch-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4388

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e917f84 with merge base 2d258fe (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugFix CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ReplayBuffers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant