Repository navigation
[release/1.6] Suppress AMD export complexity lint inline - #24511
Merged
JacobSzwejbka merged 2 commits intoNov 3, 2026
Merged
Conversation
Extract Triton source discovery into a helper, reducing main from complexity 13 to 10. Keep the release ROCm compile options, validation order, error messages and generated-code checks unchanged. Prepared with OpenAI Codex.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24511
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit ab77fc8 with merge base 4db778e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Restore the original export script and suppress complexity only on main, as requested. The script AST is unchanged from the release baseline and the repository Flake8 check passes. Prepared with OpenAI Codex.
JacobSzwejbka
changed the title
shoumikhin
approved these changes
Nov 3, 2026
JacobSzwejbka
deleted the
codex/release-1.6-fix-amd-export-lint-20261103
branch
November 3, 2026 18:03
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the release branch Lint failure:
examples/cuda/scripts/export_amd_pointwise.pyfails Flake8 C901 becausemainhas complexity 13, above the repository limit of 12.As requested, add only
# noqa: C901to the existingmaindefinition. The earlier refactor is removed; the original script logic, ROCm settings and validation checks are restored. All other lint checks remain active.Verification
The repository-configured Flake8 check passes. AST comparison verifies that the entire script is identical to the release baseline apart from the comment.
The final PR diff changes one line in one file. Full ROCm export was not run locally on macOS; no executable code changes.
Prepared with OpenAI Codex.