Repository navigation
[release/1.6] Fix NXP MCUXpresso CIFAR link failure - #24509
Merged
JacobSzwejbka merged 1 commit intoNov 3, 2026
Merged
Conversation
Compile the SDK sys_info implementation called by the CIFAR example. Use the SDK version parser to provide the version-string macro that the SDK normally supplies through its generated build header. Prepared with OpenAI Codex.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24509
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 79 PendingAs of commit a720b6c with merge base 4db778e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
rascani
approved these changes
Nov 3, 2026
JakeStevens
pushed a commit
to JakeStevens/executorch
that referenced
this pull request
Nov 3, 2026
Main-branch counterpart of release/1.6 fix pytorch#24509. Fixes the NXP MCUXpresso failure seen on pytorch#24490; main has the same incomplete CMake target. The [failed job](https://github.com/pytorch/executorch/actions/runs/41601038988/job/125799646998) reaches the final CIFAR firmware link, then fails with `undefined reference to SYS_INFO_PrintAll`. The SDK example calls this helper, but our standalone CMake target omits `examples/eiq_examples/common/sys_info/sys_info.c`. Add that source to the firmware target. The helper also needs `MCUXSDK_VERSION_FULL_STR`, which the SDK's normal build supplies through a generated header. Our standalone target now uses the SDK's `mcux_version.cmake` parser and sets the equivalent compile definition from the checked-out SDK version. ## Verification A focused host CMake build reused the actual example target's source list and include paths, the real SDK helper/header, and the SDK version parser. The board/runtime sources were replaced with empty fixtures and the application with a small C++ caller. The original source list reproduced the unresolved `SYS_INFO_PrintAll` link error. Adding only the helper reproduced the missing `MCUXSDK_VERSION_FULL_STR` compile error. With both changes, the executable linked and printed `MCUX SDK version: 2026.12.00-pvw1`. `git diff --check` passed. The full ARM firmware build and execution on hardware were not run locally; the NXP CI job must validate the complete build. Only the example's CMakeLists.txt changes (eight added lines). The resulting file is byte-identical to the verified release fix in pytorch#24509. Land this on main; pytorch#24509 is the corresponding release/1.6 pick. Prepared with OpenAI Codex.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the NXP MCUXpresso failure seen on #24490 and on the release branch.
The failed job reaches the final CIFAR firmware link, then fails with
undefined reference to SYS_INFO_PrintAll. The SDK example calls this helper, but our standalone CMake target omitsexamples/eiq_examples/common/sys_info/sys_info.c.Add that source to the firmware target. The helper also needs
MCUXSDK_VERSION_FULL_STR, which the SDK's normal build supplies through a generated header. Our standalone target now uses the SDK'smcux_version.cmakeparser and sets the equivalent compile definition from the checked-out SDK version.Verification
A focused host CMake build reused the actual example target's source list and include paths, the real SDK helper/header, and the SDK version parser. The board/runtime sources were replaced with empty fixtures and the application with a small C++ caller.
The original source list reproduced the unresolved
SYS_INFO_PrintAlllink error. Adding only the helper reproduced the missingMCUXSDK_VERSION_FULL_STRcompile error. With both changes, the executable linked and printedMCUX SDK version: 2026.12.00-pvw1.git diff --checkpassed. The full ARM firmware build and execution on hardware were not run locally; the NXP CI job must validate the complete build.Only the example's CMakeLists.txt changes (eight added lines). Based on release/1.6 after #24490; this PR can land independently of the remaining clean backend picks.
Prepared with OpenAI Codex.