Qualcomm AI Engine Direct - Add templated AdamW optimizer to training extension - #22916
quic-xiyushi wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22916
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 72be37f with merge base d32fa30 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @quic-xiyushi! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@pytorchbot label "release notes: qualcomm" |
pytorch-bot
Bot
added
the
release notes: qualcomm
… extension (based on pytorch#18848 and pytorch#22857) - Carries over the AdamW optimizer changes from pytorch#18848 - Incorporates the allocation-safety and test-coverage fixes from pytorch#22857 - Add Float and Half AdamW support with dtype, shape, layout, and CPU validation
e83c2cd to
72be37f
Compare
|
Hi @psiddh, this is the pr I mentioned that would be raised on our side. I think Harsh has to add @quic-xiyushi to the contributors list for the Meta CLA to pass, right? |
2 participants
Based on #18848 and #22857.
Summary
Test plan
buck2 test //extension/training/optimizer/test:adamw_test passes all 9 tests.