Conversation
test_mobilebert_qat_a8w8 builds a transformers TrainingArguments, which
requires accelerate>=1.1.0. The job installs only evaluate, so the test
has errored since it started running:
ImportError: Using the `Trainer` with `PyTorch` requires
`accelerate>=1.1.0`
It is the sole error in the suite on every affected commit -- "Ran 12
tests ... FAILED (errors=1)" -- and the non-zero exit reddens the trunk
workflow, which update-viablestrict requires. Pinned rather than bare,
because transformers raises the same error for a too-old version.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22870
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 1 Pending, 3 Unrelated FailuresAs of commit 66f1852 with merge base 63d5e55 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The required test dependency is added with no unresolved review issues.
Pull request overview
Adds the missing accelerate>=1.1.0 dependency required by Samsung MobileBERT QAT tests.
Changes:
- Installs
acceleratealongsideevaluate. - Documents the dependency requirement.
File summaries
| File | Description |
|---|---|
.github/workflows/trunk.yml |
Updates Samsung model-test dependencies. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
test-samsung-models-linux, red onmainsince the job started running on Sep 14.The bug
test_mobilebert_qat_a8w8constructs atransformersTrainingArguments, which requiresaccelerate>=1.1.0. The job installs onlyevaluate, so:It is the sole error in the suite, identically, on every affected commit:
f3c08fcf35Ran 12 tests ... FAILED (errors=1)4798a676c3Ran 12 tests ... FAILED (errors=1)500849ba5bRan 12 tests ... FAILED (errors=1)cfc96cc0e2Ran 12 tests ... FAILED (errors=1)026ca3fff3Ran 12 tests ... FAILED (errors=1)accelerateappears nowhere in the job logs, so it is absent rather than stale — but the pin isstill the right form, because
transformersraises the same error for a too-old version.Why it matters beyond the test
The non-zero exit propagates:
unittestexits 1 → the script runs underset -ex→run_with_env_secrets.pyraises → the job fails → thetrunkworkflow concludes failure.trunkis in
update-viablestrict'srequireslist, so the commit is disqualified andviable/stricthasnot advanced since Sep 14. This is one of two blockers; the other is the
parallel_forempty-rangebug, fixed separately in #22869. Both are needed — each independently reddens
trunk.Verification
Honest scope: I verified the diagnosis, not the fix. The sole error is identical across five
commits and
accelerateis never installed in the job. I cannot run this job — it needs theSamsung device and
SAMSUNG_AI_LITECORE_KEY— so the one-liner itself is untested.trunk.ymlparses and
lintrunneris clean.One note for reviewers: the
[CDI: ERROR] only support axis as 1/OP LOGSOFTMAXlines in the logappear after
FAILED (errors=1). They are teardown noise from a passing test, not a secondfailure.
cc @digantdesai
Authored with Claude Code.