Skip to content

Install accelerate for the Samsung model tests - #22870

Open
psiddh wants to merge 1 commit into
pytorch:mainfrom
psiddh:fix-samsung-accelerate-dep
Open

psiddh wants to merge 1 commit into
pytorch:mainfrom
psiddh:fix-samsung-accelerate-dep

Conversation

@psiddh

@psiddh psiddh commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Fixes test-samsung-models-linux, red on main since the job started running on Sep 14.

The bug

test_mobilebert_qat_a8w8 constructs a transformers TrainingArguments, which requires
accelerate>=1.1.0. The job installs only evaluate, so:

ImportError: Using the `Trainer` with `PyTorch` requires `accelerate>=1.1.0`

It is the sole error in the suite, identically, on every affected commit:

Commit Result
f3c08fcf35 Ran 12 tests ... FAILED (errors=1)
4798a676c3 Ran 12 tests ... FAILED (errors=1)
500849ba5b Ran 12 tests ... FAILED (errors=1)
cfc96cc0e2 Ran 12 tests ... FAILED (errors=1)
026ca3fff3 Ran 12 tests ... FAILED (errors=1)

accelerate appears nowhere in the job logs, so it is absent rather than stale — but the pin is
still the right form, because transformers raises the same error for a too-old version.

Why it matters beyond the test

The non-zero exit propagates: unittest exits 1 → the script runs under set -ex
run_with_env_secrets.py raises → the job fails → the trunk workflow concludes failure. trunk
is in update-viablestrict's requires list, so the commit is disqualified and viable/strict has
not advanced since Sep 14. This is one of two blockers; the other is the parallel_for empty-range
bug, fixed separately in #22869. Both are needed — each independently reddens trunk.

Verification

Honest scope: I verified the diagnosis, not the fix. The sole error is identical across five
commits and accelerate is never installed in the job. I cannot run this job — it needs the
Samsung device and SAMSUNG_AI_LITECORE_KEY — so the one-liner itself is untested. trunk.yml
parses and lintrunner is clean.

One note for reviewers: the [CDI: ERROR] only support axis as 1 / OP LOGSOFTMAX lines in the log
appear after FAILED (errors=1). They are teardown noise from a passing test, not a second
failure.

cc @digantdesai


Authored with Claude Code.

test_mobilebert_qat_a8w8 builds a transformers TrainingArguments, which
requires accelerate>=1.1.0. The job installs only evaluate, so the test
has errored since it started running:

    ImportError: Using the `Trainer` with `PyTorch` requires
    `accelerate>=1.1.0`

It is the sole error in the suite on every affected commit -- "Ran 12
tests ... FAILED (errors=1)" -- and the non-zero exit reddens the trunk
workflow, which update-viablestrict requires. Pinned rather than bare,
because transformers raises the same error for a too-old version.
Copilot AI lite review requested due to automatic review settings September 16, 2026 08:19
@pytorch-bot

pytorch-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22870

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 3 Unrelated Failures

As of commit 66f1852 with merge base 63d5e55 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2026
@psiddh psiddh added module: ci Issues related to continuous integration release notes: none Do not include this in the release notes labels Sep 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The required test dependency is added with no unresolved review issues.

Pull request overview

Adds the missing accelerate>=1.1.0 dependency required by Samsung MobileBERT QAT tests.

Changes:

  • Installs accelerate alongside evaluate.
  • Documents the dependency requirement.
File summaries
File Description
.github/workflows/trunk.yml Updates Samsung model-test dependencies.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: ci Issues related to continuous integration release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants