Skip to content

Fix parallel_for_no_threadpool invoking the callback for an empty range #22869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psiddh merged 1 commit into from
Sep 16, 2026
+7 −0
Merged

Fix parallel_for_no_threadpool invoking the callback for an empty range #22869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions runtime/kernel/thread_parallel_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ inline bool parallel_for_no_threadpool(
begin,
end);
ET_CHECK_OR_RETURN_FALSE(grain_size > 0, "grain_size = %" PRId64, grain_size);
// An empty range runs no work items, so the callback is not invoked. Checked
// here rather than only in the release branch below: the debug branch skips
// it as a side effect of iterating an empty range, and relying on that made
// the two branches disagree.
if (begin == end) {
return true;
}
#ifndef NDEBUG
// Go backwards through the range elementwise to catch code that
// assumes parallel_for is in order like a regular for loop.
Expand Down
Loading