Arm backend: Rewrite cat->slice patterns - #22868
Open
oscarandersson8218 wants to merge 2 commits into
Open
oscarandersson8218 wants to merge 2 commits into
oscarandersson8218 wants to merge 2 commits into
Conversation
Add RewriteCatSlicePass to rewrite static unit-stride slices along a concat dimension in terms of their overlapping original inputs. Only rewrite complete groups of slice users when the replacement does not increase the operation count. Preserve qparams for cat's tensor-list input and void materializing no-op slices for complete inputs. This avoids materializing an intermediate concat when only part of its result is needed. Change-Id: I93b2f987948ff715063e3dcfdf6d8efd501434f9 Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22868
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 2 Pending, 2 Unrelated FailuresAs of commit 5dd9b9f with merge base b0bc7b2 ( CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: Iefce2ef195b47b3b7aeb7c01e87f2b8789d8c943
oscarandersson8218
force-pushed
the
rewrite_cat_slices
branch
from
September 16, 2026 07:56
c865dd9 to
5dd9b9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RewriteCatSlicePass to rewrite static unit-stride slices along a concat dimension in terms of their overlapping original inputs.
Only rewrite complete groups of slice users when the replacement does not increase the operation count. Preserve qparams for cat's tensor-list input and void materializing no-op slices for complete inputs.
This avoids materializing an intermediate concat when only part of its result is needed.
cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell @rascani