Conversation
Enable cancel-in-progress for CUDA, CUDA Windows, and ROCm so older runs are canceled when a pull request is updated. Authored with Codex.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22847
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Pending, 1 Unclassified FailureAs of commit ca3b92c with merge base f5e1369 ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@claude Do we need to rewrite the concurrency group like pull or trunk workflows here too |
|
Claude finished @huydhn's task in 1m 24s —— View job AnswerNo — you don't need to rewrite the concurrency group. The group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref_name }}-${{ github.ref_type == 'branch' && github.sha }}-${{ github.event_name == 'workflow_dispatch' }}-${{ github.event_name == 'schedule' }}This PR only flips Why the group is fine as-is (and why it differs from
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name == 'workflow_dispatch' && github.run_id }}-${{ github.event_name == 'schedule' }}The two meaningful differences are intentional and appropriate for accelerator/trunk-style workflows:
Recommendation: Keep the group as-is. Matching · branch |
Fixes #22845.
CUDA, CUDA Windows, and ROCm workflows currently keep older runs active when a pull request is updated. This enables concurrency cancellation for those workflows, consistent with the other ExecuTorch CI workflows using the same concurrency group.
Authored with Codex.