drop TARGETS files redundant with fbcode_target-wrapped BUCK siblings - #21408
Open
bigfootjon wants to merge 1 commit into
Open
drop TARGETS files redundant with fbcode_target-wrapped BUCK siblings#21408bigfootjon wants to merge 1 commit into
bigfootjon wants to merge 1 commit into
Conversation
Summary:
Chunk 10 of fbcode/executorch TARGETS->BUCK migration. 18 directories
under examples/ where TARGETS defines targets like `python_library(name=X)`
and the sister BUCK defines the same targets via the fbcode_target wrapper:
`fbcode_target(_kind = python_library, name = X)`. Both forms produce the
same logical target in fbcode; the wrapper just adds OSS-migration metadata.
Confirmed every name= in TARGETS is also in BUCK. Deleting TARGETS lets
fbcode fall through to BUCK (via name_v2 = TARGETS,BUCK) with no change in
target inventory.
Directories migrated:
- examples/models
- examples/models/{codegen,deeplab_v3,edsr,emformer_rnnt,glm,granite,
inception_v3,mobilebert,mobilenet_v2,smollm2,smollm3,smolvlm,
torchvision_vit,toy_model,wav2letter}
- examples/portable/scripts
- examples/xnnpack/quantization
Reviewed By: mzlee
Differential Revision: D109082050
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21408
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unrelated FailuresAs of commit 39cd078 with merge base 55d693b ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082050. |
This PR needs a
|
Contributor
There was a problem hiding this comment.
Pull request overview
Continues the fbcode TARGETS→BUCK migration under examples/ by removing redundant TARGETS files where equivalent targets are already defined via fbcode_target(...) in sibling BUCK files, so fbcode can fall through to BUCK without changing the intended target set.
Changes:
- Delete redundant
TARGETSfiles across the listedexamples/directories soname_v2 = TARGETS,BUCKresolves viaBUCK. - Adjust
examples/models/BUCKto drop references towhisperandyolo26from themodelspython_library deps list.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/models/BUCK | Removes whisper/yolo26 deps from //executorch/examples/models:models. |
| examples/models/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/codegen/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/deeplab_v3/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/edsr/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/emformer_rnnt/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/glm/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/granite/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/inception_v3/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/mobilebert/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/mobilenet_v2/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/smollm2/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/smollm3/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/smolvlm/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/torchvision_vit/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/toy_model/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/models/wav2letter/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/portable/scripts/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
| examples/xnnpack/quantization/TARGETS (deleted) | Remove redundant TARGETS to fall through to BUCK. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
34
to
37
| "//executorch/examples/models/smollm2:smollm2", # @manual | ||
| "//executorch/examples/models/smollm3:smollm3", # @manual | ||
| "//executorch/examples/models/smolvlm:smolvlm", # @manual | ||
| "//executorch/examples/models/whisper:whisper", # @manual | ||
| "//executorch/examples/models/yolo26:yolo26", # @manual | ||
| ], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Chunk 10 of fbcode/executorch TARGETS->BUCK migration. 18 directories
under examples/ where TARGETS defines targets like
python_library(name=X)and the sister BUCK defines the same targets via the fbcode_target wrapper:
fbcode_target(_kind = python_library, name = X). Both forms produce thesame logical target in fbcode; the wrapper just adds OSS-migration metadata.
Confirmed every name= in TARGETS is also in BUCK. Deleting TARGETS lets
fbcode fall through to BUCK (via name_v2 = TARGETS,BUCK) with no change in
target inventory.
Directories migrated:
inception_v3,mobilebert,mobilenet_v2,smollm2,smollm3,smolvlm,
torchvision_vit,toy_model,wav2letter}
Reviewed By: mzlee
Differential Revision: D109082050