Un-skip sum dim=None U55/U85 tests; fix stale addmm xfail reason - #21407
Un-skip sum dim=None U55/U85 tests; fix stale addmm xfail reason#21407psiddh wants to merge 1 commit into
Conversation
Summary: Two test-hygiene fixes in the Arm backend test suite, both reducing the `ai_infra_mobile_platform` SKIPPING oncall bucket for `executorch/backends/arm`. - `test_sum.py`: `test_sum_u55_INT_1_0` / `test_sum_u85_INT_1_0` were skipping the `dim_None` and `dim_None_4d_tensor` cases because the FVP bundled program cannot serialize `None` as a model input. `dim`/`keepdim` were passed as `forward` arguments, so they became model inputs. A new `SumDimNone` module bakes `dim=None` into the module, leaving only the tensor as an input, so the cases now run and pass on both U55 and U85 instead of being skipped. The non-`None` cases are unchanged. (The TOSA path already ran these un-skipped.) - `test_addmm.py`: the `test_addmm_16a8w_u55_INT` xfail reason claimed "Vela compilation fails with 'Invalid arguments'", but the test actually fails at runtime on the Corstone-300 U55 FVP (method load status `0x14`); Vela compilation succeeds. Corrected the reason string to describe the observed failure so the next investigator is not misled. The test still xfails. Authored with Claude Code. Differential Revision: D113676338
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21407
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 5be00a1 with merge base 55d693b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113676338. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR improves Arm backend test hygiene by (1) enabling previously skipped Ethos-U55/U85 sum(dim=None) test cases in the FVP path by baking dim=None into the module, and (2) correcting a stale/incorrect xfail reason for an addmm int16 test so failures are attributed to the right stage (runtime load vs. Vela compile).
Changes:
- Add a
SumDimNonemodule and routedim=Nonetest vectors through it so the FVP bundled program doesn’t need to serializeNoneas an input. - Remove skip logic for
dim=Nonecases in U55/U85sumINT tests by switching to module+inputs selection. - Update
test_addmm_16a8w_u55_INTxfail reason to reflect the observed U55 FVP load failure (status0x14).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backends/arm/test/ops/test_sum.py | Introduces SumDimNone + helper to un-skip dim=None U55/U85 cases in the FVP pipeline. |
| backends/arm/test/ops/test_addmm.py | Updates the xfail reason string to match the actual failing stage (FVP load). |
Comments suppressed due to low confidence (2)
backends/arm/test/ops/test_sum.py:124
test_datais a callable parameter (provided bycommon.parametrize) and is used as such via_module_and_inputs(test_data). The currentTupleannotation is inaccurate and inconsistent with other tests in this file.
def test_sum_u55_INT_1_0(test_data: Tuple):
backends/arm/test/ops/test_sum.py:137
- Same as above:
test_datais a callable fromcommon.parametrize, but is annotated asTuple. Align the signature with the rest of the file for clarity and static checking.
def test_sum_u85_INT_1_0(test_data: Tuple):
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "dim_None": _DIM_NONE_SKIP_REASON, | ||
| "dim_None_4d_tensor": _DIM_NONE_SKIP_REASON, | ||
| } | ||
| def _module_and_inputs(test_data: Tuple): |
Summary:
Two test-hygiene fixes in the Arm backend test suite, both reducing the
ai_infra_mobile_platformSKIPPING oncall bucket forexecutorch/backends/arm.test_sum.py:test_sum_u55_INT_1_0/test_sum_u85_INT_1_0were skippingthe
dim_Noneanddim_None_4d_tensorcases because the FVP bundled programcannot serialize
Noneas a model input.dim/keepdimwere passed asforwardarguments, so they became model inputs. A newSumDimNonemodulebakes
dim=Noneinto the module, leaving only the tensor as an input, so thecases now run and pass on both U55 and U85 instead of being skipped. The
non-
Nonecases are unchanged. (The TOSA path already ran these un-skipped.)test_addmm.py: thetest_addmm_16a8w_u55_INTxfail reason claimed "Velacompilation fails with 'Invalid arguments'", but the test actually fails at
runtime on the Corstone-300 U55 FVP (method load status
0x14); Velacompilation succeeds. Corrected the reason string to describe the observed
failure so the next investigator is not misled. The test still xfails.
Authored with Claude Code.
Differential Revision: D113676338
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani