Migrate to Graph.materialize_symints; stop passing raw SymInts#20199
Open
laithsakka wants to merge 1 commit into
Open
Migrate to Graph.materialize_symints; stop passing raw SymInts#20199laithsakka wants to merge 1 commit into
laithsakka wants to merge 1 commit into
Conversation
Summary: reland plan for pytorch/pytorch#186272 due to executorch dependency have to stage changes !! Updates the ARM backend passes (convert_full_like_to_full, decompose_linear, decompose_select, insert_dynamic_padding, rewrite_conv, size_adjust_input) and the ExportPass base to materialize SymInt-typed FX-node arguments via Graph.materialize_symints / create_size_node, so they no longer pass raw SymInts to Graph.create_node and the new pytorch warning falls silent. Test assertions in test_decompose_select_pass / test_insert_dynamic_padding_pass / test_dynamic_shape_propagation are updated to expect FX Nodes (with the SymInt stored in meta['val']). This is the second of three diffs split from D107573548. Differential Revision: D107938874
Contributor
|
@laithsakka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107938874. |
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
reland plan for pytorch/pytorch#186272 due to executorch dependency have to stage changes !!
Updates the ARM backend passes (convert_full_like_to_full,
decompose_linear, decompose_select, insert_dynamic_padding,
rewrite_conv, size_adjust_input) and the ExportPass base to materialize
SymInt-typed FX-node arguments via Graph.materialize_symints /
create_size_node, so they no longer pass raw SymInts to
Graph.create_node and the new pytorch warning falls silent.
Test assertions in test_decompose_select_pass /
test_insert_dynamic_padding_pass / test_dynamic_shape_propagation are
updated to expect FX Nodes (with the SymInt stored in meta['val']).
This is the second of three diffs split from D107573548.
Differential Revision: D107938874
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani