-
Notifications
You must be signed in to change notification settings - Fork 964
Revert "Move torch pin from the 2.11 to the 2026-04-09 nightly, and drop deprecated CUDA versions from CI" #19160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 358117c166b75167a09bca81ac9925940feda339 | ||
| release/2.11 | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -158,17 +158,17 @@ print(module_vars["TORCH_VERSION"]) | |||||||||
| PY | ||||||||||
| ) | ||||||||||
|
|
||||||||||
| NIGHTLY_VERSION=$( | ||||||||||
| "$PYBIN" - <<'PY' | ||||||||||
| import runpy | ||||||||||
| module_vars = runpy.run_path("torch_pin.py") | ||||||||||
| print(module_vars["NIGHTLY_VERSION"]) | ||||||||||
| PY | ||||||||||
| ) | ||||||||||
| echo "=== [$LABEL] Install torch==${TORCH_VERSION}.${NIGHTLY_VERSION} ===" | ||||||||||
|
|
||||||||||
| # Install torchao based on the pinned PyTorch version | ||||||||||
| "$PIPBIN" install torch=="${TORCH_VERSION}.${NIGHTLY_VERSION}" --index-url "https://download.pytorch.org/whl/nightly/cpu" | ||||||||||
| # NIGHTLY_VERSION=$( | ||||||||||
| # "$PYBIN" - <<'PY' | ||||||||||
| # import runpy | ||||||||||
| # module_vars = runpy.run_path("torch_pin.py") | ||||||||||
| # print(module_vars["NIGHTLY_VERSION"]) | ||||||||||
| # PY | ||||||||||
| # ) | ||||||||||
| echo "=== [$LABEL] Install torch==${TORCH_VERSION} ===" | ||||||||||
|
|
||||||||||
| # Install torch based on the pinned PyTorch version, preferring the PyTorch test index | ||||||||||
| "$PIPBIN" install torch=="${TORCH_VERSION}" --extra-index-url "https://download.pytorch.org/whl/test" | ||||||||||
|
Comment on lines
+170
to
+171
|
||||||||||
| # Install torch based on the pinned PyTorch version, preferring the PyTorch test index | |
| "$PIPBIN" install torch=="${TORCH_VERSION}" --extra-index-url "https://download.pytorch.org/whl/test" | |
| # Install torch from the PyTorch test CPU wheel index, while allowing PyPI for dependencies | |
| "$PIPBIN" install torch=="${TORCH_VERSION}" --index-url "https://download.pytorch.org/whl/test/cpu" --extra-index-url "https://pypi.org/simple" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,20 +33,17 @@ jobs: | |
| matrix: | ||
| runner: [linux.4xlarge] | ||
| docker-image-name: [ | ||
| executorch-ubuntu-22.04-gcc11, | ||
| executorch-ubuntu-22.04-gcc9-nopytorch, | ||
|
Comment on lines
33
to
37
|
||
| executorch-ubuntu-22.04-clang12, | ||
| executorch-ubuntu-22.04-linter, | ||
| executorch-ubuntu-22.04-arm-sdk, | ||
| executorch-ubuntu-22.04-zephyr-sdk, | ||
| executorch-ubuntu-22.04-qnn-sdk, | ||
| executorch-ubuntu-22.04-mediatek-sdk, | ||
|
Comment on lines
39
to
43
|
||
| executorch-ubuntu-22.04-clang12-android | ||
| ] | ||
| include: | ||
| # PyTorch is built from source in these images; 4xlarge OOMs mid-build. | ||
| - docker-image-name: executorch-ubuntu-22.04-gcc11 | ||
| runner: linux.12xlarge | ||
| - docker-image-name: executorch-ubuntu-22.04-zephyr-sdk | ||
| runner: linux.12xlarge | ||
| - docker-image-name: executorch-ubuntu-22.04-gcc11-aarch64 | ||
| runner: linux.arm64.2xlarge | ||
| - docker-image-name: executorch-ubuntu-22.04-gcc11-aarch64-android | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,11 +12,9 @@ | |
|
|
||
| from install_utils import determine_torch_url, is_intel_mac_os, python_is_compatible | ||
|
|
||
| from torch_pin import NIGHTLY_VERSION, TORCH_VERSION | ||
|
|
||
| # The pip repository that hosts nightly torch packages. | ||
| # This will be dynamically set based on CUDA availability and CUDA backend enabled/disabled. | ||
| TORCH_NIGHTLY_URL_BASE = "https://download.pytorch.org/whl/nightly" | ||
| TORCH_URL_BASE = "https://download.pytorch.org/whl/test" | ||
|
|
||
| # Since ExecuTorch often uses main-branch features of pytorch, only the nightly | ||
| # pip versions will have the required features. | ||
|
|
@@ -44,18 +42,14 @@ def install_requirements(use_pytorch_nightly): | |
| sys.exit(1) | ||
|
|
||
| # Determine the appropriate PyTorch URL based on CUDA delegate status | ||
| torch_url = determine_torch_url(TORCH_NIGHTLY_URL_BASE) | ||
| torch_url = determine_torch_url(TORCH_URL_BASE) | ||
|
|
||
| # pip packages needed by exir. | ||
| TORCH_PACKAGE = [ | ||
| # Setting use_pytorch_nightly to false to test the pinned PyTorch commit. Note | ||
| # that we don't need to set any version number there because they have already | ||
| # been installed on CI before this step, so pip won't reinstall them | ||
| ( | ||
| f"torch=={TORCH_VERSION}.{NIGHTLY_VERSION}" | ||
| if use_pytorch_nightly | ||
| else "torch" | ||
| ), | ||
| ("torch==2.11.0" if use_pytorch_nightly else "torch"), | ||
| ] | ||
|
Comment on lines
49
to
53
|
||
|
|
||
| # Install the requirements for core ExecuTorch package. | ||
|
|
@@ -114,20 +108,12 @@ def install_requirements(use_pytorch_nightly): | |
|
|
||
| def install_optional_example_requirements(use_pytorch_nightly): | ||
| # Determine the appropriate PyTorch URL based on CUDA delegate status | ||
| torch_url = determine_torch_url(TORCH_NIGHTLY_URL_BASE) | ||
| torch_url = determine_torch_url(TORCH_URL_BASE) | ||
|
|
||
| print("Installing torch domain libraries") | ||
| DOMAIN_LIBRARIES = [ | ||
| ( | ||
| f"torchvision==0.27.0.{NIGHTLY_VERSION}" | ||
| if use_pytorch_nightly | ||
| else "torchvision" | ||
| ), | ||
| ( | ||
| f"torchaudio==2.11.0.{NIGHTLY_VERSION}" | ||
| if use_pytorch_nightly | ||
| else "torchaudio" | ||
| ), | ||
| ("torchvision==0.26.0" if use_pytorch_nightly else "torchvision"), | ||
| ("torchaudio==2.11.0" if use_pytorch_nightly else "torchaudio"), | ||
| ] | ||
|
Comment on lines
113
to
117
|
||
| # Then install domain libraries | ||
| subprocess.run( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning to a moving ref (
release/2.11) makes builds less reproducible and also conflicts with the existing pin-bump automation (.github/scripts/update_pytorch_pin.py) which writes a commit SHA into this file. Consider pinning to a specific commit hash (or at least a tag) and updating/pausing the automation if the intent is to stay on a stable release branch long-term.