Conversation
Summary: Move slice_copy ops before permute_copy to reduce permute data volume when profitable. Only transforms single-user permutes. Cost model: dim-0 slices are nop-eligible after MakeSliceAndCatDimOutermostPass. Moving such a slice loses the nop, so we only move it when the slice removes more than half the data (permute savings outweigh the nop loss). Non-dim-0 slices have no nop opportunity, so any permute savings is pure win. Not added to CadenceReorderOpsInGraph to avoid interaction with MakeSliceAndCatDimOutermostPass in the default pipeline. Differential Revision: D102426699
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19129
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Cancelled Jobs, 1 Pending, 2 Unrelated FailuresAs of commit 2d228fc with merge base 0a43e2f ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102426699. |
This PR needs a
|
Summary:
Move slice_copy ops before permute_copy to reduce permute data volume when profitable. Only transforms single-user permutes.
Cost model: dim-0 slices are nop-eligible after MakeSliceAndCatDimOutermostPass. Moving such a slice loses the nop, so we only move it when the slice removes more than half the data (permute savings outweigh the nop loss). Non-dim-0 slices have no nop opportunity, so any permute savings is pure win.
Not added to CadenceReorderOpsInGraph to avoid interaction with MakeSliceAndCatDimOutermostPass in the default pipeline.
Differential Revision: D102426699