Skip to content

Reorder slice before permute#19129

Open
DrJessop wants to merge 1 commit intopytorch:mainfrom
DrJessop:export-D102426699
Open

Reorder slice before permute#19129
DrJessop wants to merge 1 commit intopytorch:mainfrom
DrJessop:export-D102426699

Conversation

@DrJessop
Copy link
Copy Markdown
Contributor

Summary:
Move slice_copy ops before permute_copy to reduce permute data volume when profitable. Only transforms single-user permutes.

Cost model: dim-0 slices are nop-eligible after MakeSliceAndCatDimOutermostPass. Moving such a slice loses the nop, so we only move it when the slice removes more than half the data (permute savings outweigh the nop loss). Non-dim-0 slices have no nop opportunity, so any permute savings is pure win.

Not added to CadenceReorderOpsInGraph to avoid interaction with MakeSliceAndCatDimOutermostPass in the default pipeline.

Differential Revision: D102426699

Summary:
Move slice_copy ops before permute_copy to reduce permute data volume when profitable. Only transforms single-user permutes.

Cost model: dim-0 slices are nop-eligible after MakeSliceAndCatDimOutermostPass. Moving such a slice loses the nop, so we only move it when the slice removes more than half the data (permute savings outweigh the nop loss). Non-dim-0 slices have no nop opportunity, so any permute savings is pure win.

Not added to CadenceReorderOpsInGraph to avoid interaction with MakeSliceAndCatDimOutermostPass in the default pipeline.

Differential Revision: D102426699
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 25, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19129

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Cancelled Jobs, 1 Pending, 2 Unrelated Failures

As of commit 2d228fc with merge base 0a43e2f (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 25, 2026

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102426699.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant