Skip to content

NXP backend: Unify testing infrastructure.#19112

Open
MartinPavella wants to merge 3 commits intopytorch:mainfrom
nxp-upstream:nxg01483/EIEX-896-unify-lowering-and-testing-functions
Open

NXP backend: Unify testing infrastructure.#19112
MartinPavella wants to merge 3 commits intopytorch:mainfrom
nxp-upstream:nxg01483/EIEX-896-unify-lowering-and-testing-functions

Conversation

@MartinPavella
Copy link
Copy Markdown
Collaborator

@MartinPavella MartinPavella commented Apr 24, 2026 •
edited by pytorch-bot Bot
Loading

Summary

Unify tests comparing edge dialect <-> Neutron IR with tests comparing lowered edge programs <-> lowered Neutron delegated programs.

Test plan

Tested by all existing tests.

cc @robert-kalmar @JakeStevens @digantdesai

@MartinPavella MartinPavella self-assigned this Apr 24, 2026
@MartinPavella MartinPavella added the module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ label Apr 24, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 24, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19112

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit b32f480 with merge base c8c791a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@MartinPavella
Copy link
Copy Markdown
Collaborator Author

MartinPavella commented Apr 24, 2026 •
edited
Loading

Corresponding internal PR is here.
The internal CI build is here.

JakeStevens
JakeStevens reviewed Apr 25, 2026
View reviewed changes
Comment thread backends/nxp/tests/generic_tests/test_aot_example.py
@@ -16,7 +16,7 @@ def test_aot_example__mobilenet_v2():
"""Test that mobilenet can be lowered to Neutron backend via `aot_neutron_compile.py` and all ops are delegated."""

# Find the executorch root directory (4 levels up from this test file)
Copy link
Copy Markdown
Contributor

@JakeStevens JakeStevens Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 5 levels up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeStevens JakeStevens JakeStevens left review comments

@StrycekSimon StrycekSimon Awaiting requested review from StrycekSimon

@roman-janik-nxp roman-janik-nxp Awaiting requested review from roman-janik-nxp

@robert-kalmar robert-kalmar Awaiting requested review from robert-kalmar robert-kalmar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@MartinPavella MartinPavella

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MartinPavella @JakeStevens