Skip to content

[ET-VK] Add ANY_STORAGE support to embedding #18057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SS-JIA wants to merge 1 commit into
base: gh/SS-JIA/474/base
Choose a base branch
from
Open

[ET-VK] Add ANY_STORAGE support to embedding #18057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/vulkan/op_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,7 @@ def register_repeat():
@update_features(exir_ops.edge.aten.embedding.default)
def register_embedding():
return OpFeatures(
inputs_storage=utils.CHANNELS_PACKED_TEXTURE,
inputs_storage=utils.ANY_STORAGE,
inputs_dtypes=[utils.FP_T, utils.INT_T],
supports_prepacking=True,
supports_resize=True,
Expand Down
5 changes: 2 additions & 3 deletions backends/vulkan/test/op_tests/cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,14 +1130,13 @@ def get_embedding_inputs():
Test(weight=[10, 9], indices=[[1, 2, 3], [1, 2, 3], [1, 2, 3], [1, 2, 3]]),
]

# Channels packed test cases currently fail on Mac, so they are not included.
# However the test case definition is kept for later debugging.
test_suite_cpack = VkTestSuite(
[tuple(tc) + (-1, "false", "false") for tc in test_cases]
)

test_suite_cpack.dtypes = ["at::kFloat"]
test_suite_cpack.layouts = ["utils::kChannelsPacked"]
test_suite_cpack.storage_types = ["utils::kBuffer", "utils::kTexture3D"]
test_suite_cpack.test_name_suffix = "cpacked"

test_suite_wpack = VkTestSuite(
Expand All @@ -1149,7 +1148,7 @@ def get_embedding_inputs():
test_suite_wpack.storage_types = ["utils::kBuffer", "utils::kTexture3D"]
test_suite_wpack.test_name_suffix = "wpacked"

return test_suite_wpack
return [test_suite_cpack, test_suite_wpack]


@register_test_suite("aten.gather.default")
Expand Down
Loading