Skip to content

Arm backend: Pin pybind11 version when installing tosa_serialization #18036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tom-arm wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −0
Open

Arm backend: Pin pybind11 version when installing tosa_serialization #18036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dd504e
Arm backend: Pin pybind11 version when installing tosa_serialization
tom-arm Mar 9, 2026
7c4a779
Add note informing pin will be removed
tom-arm Mar 10, 2026
48d0a73
Merge branch 'main' into pin_pybind11
tom-arm Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci/scripts/unittest-linux-cmake.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ if ! python -c "import tosa_serializer" >/dev/null 2>&1; then
TOSA_SERIALIZATION_DIR="${TOSA_TOOLS_DIR}/serialization"
fi

# NOTE: Will be removed when tosa-tools is installed via pypi
python -m pip install pybind11==2.10.4
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pybind11 pin duplicates the version in backends/arm/requirements-arm-tosa.txt. To reduce the chance of the two pins diverging, consider deriving the version from a single source (e.g., install -r backends/arm/requirements-arm-tosa.txt/a shared constraints file, or define a single variable that both paths use).

Suggested change
python -m pip install pybind11==2.10.4
python -m pip install -r backends/arm/requirements-arm-tosa.txt

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@tom-arm tom-arm Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will install unnecessary dependencies, so I will not take this suggestion

CMAKE_POLICY_VERSION_MINIMUM=3.5 BUILD_PYBIND=1 \
python -m pip install --no-dependencies \
"${TOSA_SERIALIZATION_DIR}"
Expand Down
2 changes: 2 additions & 0 deletions backends/arm/requirements-arm-tosa.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ ml_dtypes == 0.5.1
flatbuffers == 24.3.25
tosa-adapter-model-explorer == 0.1.0
ai-edge-model-explorer >= 0.1.16
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pybind11 version is pinned here, but the same version is also hard-coded in .ci/scripts/unittest-linux-cmake.sh. This duplication is easy to let drift and can create CI vs local setup mismatches. Consider centralizing the pin (e.g., a shared constraints file or having CI install from this requirements file) or add an explicit note that the CI script must be kept in sync.

Suggested change
ai-edge-model-explorer >= 0.1.16
ai-edge-model-explorer >= 0.1.16
# NOTE: pybind11 version must be kept in sync with .ci/scripts/unittest-linux-cmake.sh

Copilot uses AI. Check for mistakes.
# NOTE: Will be removed when tosa-tools is installed via pypi
pybind11 == 2.10.4
Loading