-
Notifications
You must be signed in to change notification settings - Fork 716
Arm backend: Improve support for multiple output ops #15695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern of using .name from the TosaArg output is used in essentially all node visitors. Refactoring output to possibly be a list of TosaArgs would be very cumbersome. Instead, use a new multiple_output_names field to provide the names of all getitem tensors. This also means that we don't have to insert identity ops for getitem operators, they just need to insert a tensor. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ic7c87ea0c8c3b633704749611354dfb15273df16
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15695
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 6 Unrelated FailuresAs of commit 7e2e5ed with merge base c8e9684 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
Unrelated failure, should be buck safe |
zingo
approved these changes
Nov 11, 2025
Collaborator
|
fails are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
release notes: none
Do not include this in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern of using .name from the TosaArg output is used in essentially all node visitors. Refactoring output to possibly be a list of TosaArgs would be very cumbersome. Instead, use a new multiple_output_names field to provide the names of all getitem tensors. This also means that we don't have to insert identity ops for getitem operators, they just need to insert a tensor.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai