Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Nov 10, 2025

The pattern of using .name from the TosaArg output is used in essentially all node visitors. Refactoring output to possibly be a list of TosaArgs would be very cumbersome. Instead, use a new multiple_output_names field to provide the names of all getitem tensors. This also means that we don't have to insert identity ops for getitem operators, they just need to insert a tensor.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

The pattern of using .name from the TosaArg output is
used in essentially all node visitors. Refactoring output
to possibly be a list of TosaArgs would be very cumbersome.
Instead, use a new multiple_output_names field to provide
the names of all getitem tensors. This also means that we
don't have to insert identity ops for getitem operators,
they just need to insert a tensor.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: Ic7c87ea0c8c3b633704749611354dfb15273df16
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15695

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 6 Unrelated Failures

As of commit 7e2e5ed with merge base c8e9684 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Nov 10, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025
@Erik-Lundell
Copy link
Collaborator Author

Unrelated failure, should be buck safe

@zingo
Copy link
Collaborator

zingo commented Nov 11, 2025

fails are unrelated

@zingo zingo merged commit b84f372 into pytorch:main Nov 11, 2025
287 of 296 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants