Draft
Conversation
github-actions
Bot
added
component: tests
narendasan
reviewed
Apr 24, 2026
| assert engine_cache is not None | ||
| assert hash_val is not None | ||
|
|
||
| _lock_path = _os.path.join(engine_cache.engine_cache_dir, f".{hash_val}.lock") |
Collaborator
There was a problem hiding this comment.
You should build a locking facility into the core BaseEngineCache class so that if someone uses some other method other than disk cache it still works the same. For DiskCache FileLocks might be the right choice but say you use S3 buckets, it might be something else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.