-
Notifications
You must be signed in to change notification settings - Fork 381
lowering pass: fully remove SymInt #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
narendasan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test case
| and issubclass(node.type, torch.Tensor) | ||
| ): | ||
| for symint_node, (arg_name, idx) in symint_node_arg_dict.items(): | ||
| if node.target == "L_" + arg_name + "_": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this name template be consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same concern. Is there any other ways to identify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's torch generated internal name so it should be consistent if torch doesn't change the design. Anyways I changed to a more robust way to do it.
Description
Added a lowering pass to replace SymInt with aten.sym_size. Users now can explicitly use dynamic dims in the models. e.g.:
Fixes #3981
Type of change
Checklist: