Support 2D weights permute for strided keys #5145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kausv
added a commit
to kausv/FBGEMM
that referenced
this pull request
Nov 18, 2025
Summary: X-link: facebookresearch/FBGEMM#2144 Support 2D weights in 1D length permute tensor kernel. This kernel is invoked on variable strides per rank. Similar to D80466458 https://www.internalfb.com/code/fbsource/[5e1d1c3734c75d0664ba817ee05ce9a91a1f02e4]/fbcode/torchrec/sparse/jagged_tensor.py?lines=3111-3134 2D weights are needed for write dist where the weights are actually embedding values. Differential Revision: D87261479
kausv
force-pushed
the
export-D87261479
branch
from
605c525 to
2ca62d8
Compare
kausv
added a commit
to kausv/FBGEMM
that referenced
this pull request
Nov 18, 2025
Summary: X-link: facebookresearch/FBGEMM#2144 Support 2D weights in 1D length permute tensor kernel. This kernel is invoked on variable strides per rank. Similar to D80466458 https://github.com/meta-pytorch/torchrec/blob/main/torchrec/sparse/jagged_tensor.py#L3111-L3134 2D weights are needed for write dist where the weights are actually embedding values. Differential Revision: D87261479
kausv
force-pushed
the
export-D87261479
branch
from
2ca62d8 to
0b1e7ca
Compare
kausv
added a commit
to kausv/FBGEMM
that referenced
this pull request
Nov 18, 2025
Summary: X-link: facebookresearch/FBGEMM#2144 Support 2D weights in 1D length permute tensor kernel. This kernel is invoked on variable strides per rank. Similar to D80466458 https://github.com/meta-pytorch/torchrec/blob/main/torchrec/sparse/jagged_tensor.py#L3111-L3134 2D weights are needed for write dist where the weights are actually embedding values. Reviewed By: spcyppt, q10 Differential Revision: D87261479
kausv
force-pushed
the
export-D87261479
branch
from
0b1e7ca to
a7a3eef
Compare
kausv
added a commit
to kausv/FBGEMM
that referenced
this pull request
Nov 18, 2025
Summary: X-link: facebookresearch/FBGEMM#2144 Support 2D weights in 1D length permute tensor kernel. This kernel is invoked on variable strides per rank. Similar to D80466458 https://github.com/meta-pytorch/torchrec/blob/main/torchrec/sparse/jagged_tensor.py#L3111-L3134 2D weights are needed for write dist where the weights are actually embedding values. Reviewed By: spcyppt, q10 Differential Revision: D87261479
kausv
force-pushed
the
export-D87261479
branch
from
a7a3eef to
1a5f558
Compare
Summary: X-link: facebookresearch/FBGEMM#2144 Support 2D weights in 1D length permute tensor kernel. This kernel is invoked on variable strides per rank. Similar to D80466458 https://github.com/meta-pytorch/torchrec/blob/main/torchrec/sparse/jagged_tensor.py#L3111-L3134 2D weights are needed for write dist where the weights are actually embedding values. Reviewed By: spcyppt, q10 Differential Revision: D87261479
kausv
force-pushed
the
export-D87261479
branch
from
1a5f558 to
64df814
Compare
Contributor
|
This pull request has been merged in e1fc43e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2144
Support 2D weights in 1D length permute tensor kernel.
This kernel is invoked on variable strides per rank
https://github.com/meta-pytorch/torchrec/blob/main/torchrec/sparse/jagged_tensor.py#L3111-L3134
2D weights are needed for write dist where the weights are actually embedding values.
Differential Revision: D87261479