Vectorize requantize_ for Arm64 with NEON intrinsics #5130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcfi
added a commit
to mcfi/FBGEMM
that referenced
this pull request
Nov 14, 2025
Summary: Pull Request resolved: pytorch#5130 X-link: https://github.com/facebookresearch/FBGEMM/pull/2132 This change added a vectorized requantize_ for Arm64 with NEON intrinsics: 1. The newly added NEON intrinsics follows what the existing AVX2 code does. 2. The scalar loop was moved to a new function requantize_i8dw_ref_ to make the code more readable and testable. 3. Added new tests to make requantize_ and requantize_i8dw_ref_ produce identical results. Differential Revision: D86216347
mcfi
force-pushed
the
export-D86216347
branch
from
a4ec8c4 to
fe324d6
Compare
mcfi
added a commit
to mcfi/FBGEMM
that referenced
this pull request
Nov 14, 2025
Summary: Pull Request resolved: pytorch#5130 X-link: https://github.com/facebookresearch/FBGEMM/pull/2132 This change added a vectorized requantize_ for Arm64 with NEON intrinsics: 1. The newly added NEON intrinsics follows what the existing AVX2 code does. 2. The scalar loop was moved to a new function requantize_i8dw_ref_ to make the code more readable and testable. 3. Added new tests to make requantize_ and requantize_i8dw_ref_ produce identical results. Differential Revision: D86216347
mcfi
force-pushed
the
export-D86216347
branch
from
fe324d6 to
a2e3ba0
Compare
mcfi
added a commit
to mcfi/FBGEMM
that referenced
this pull request
Nov 14, 2025
Summary: Pull Request resolved: pytorch#5130 X-link: https://github.com/facebookresearch/FBGEMM/pull/2132 This change added a vectorized requantize_ for Arm64 with NEON intrinsics: 1. The newly added NEON intrinsics follows what the existing AVX2 code does. 2. The scalar loop was moved to a new function requantize_i8dw_ref_ to make the code more readable and testable. 3. Added new tests to make requantize_ and requantize_i8dw_ref_ produce identical results. Differential Revision: D86216347
mcfi
force-pushed
the
export-D86216347
branch
from
a2e3ba0 to
35855d6
Compare
mcfi
added a commit
to mcfi/FBGEMM
that referenced
this pull request
Nov 14, 2025
Summary: Pull Request resolved: pytorch#5130 X-link: https://github.com/facebookresearch/FBGEMM/pull/2132 This change added a vectorized requantize_ for Arm64 with NEON intrinsics: 1. The newly added NEON intrinsics follows what the existing AVX2 code does. 2. The scalar loop was moved to a new function requantize_i8dw_ref_ to make the code more readable and testable. 3. Added new tests to make requantize_ and requantize_i8dw_ref_ produce identical results. Differential Revision: D86216347
mcfi
force-pushed
the
export-D86216347
branch
from
35855d6 to
a4f2e8e
Compare
Summary: Pull Request resolved: pytorch#5130 X-link: https://github.com/facebookresearch/FBGEMM/pull/2132 This change added a vectorized requantize_ for Arm64 with NEON intrinsics: 1. The newly added NEON intrinsics follows what the existing AVX2 code does. 2. The scalar loop was moved to a new function requantize_i8dw_ref_ to make the code more readable and testable. 3. Added new tests to make sure requantize_ and requantize_i8dw_ref_ produce identical results. Reviewed By: Nicoshev Differential Revision: D86216347
mcfi
force-pushed
the
export-D86216347
branch
from
a4f2e8e to
b557c97
Compare
Contributor
|
This pull request has been merged in 643894e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change added a vectorized requantize_ for Arm64 with NEON intrinsics:
Differential Revision: D86216347