Skip to content

Add conformance test for @final combined with @property #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samwgoldman wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add conformance test for @final combined with @property #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52aad76
Add conformance test for @final-decorated @property
samwgoldman Jan 31, 2025
06ce4cc
Add example of @final with @property to the typing spec
samwgoldman Jan 31, 2025
f4d1db6
Update conformance result for pyright/qualifiers_final_decorator.toml
samwgoldman Jan 31, 2025
b6d56e3
Merge remote-tracking branch 'upstream/main' into codex/pr-1916-merge…
JelleZijlstra Aug 7, 2026
e49ef3b
align wording
JelleZijlstra Aug 7, 2026
c4ed290
line numbers changed
JelleZijlstra Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions conformance/results/mypy/qualifiers_final_decorator.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
conformant = "Pass"
output = """
qualifiers_final_decorator.py:21: error: Cannot inherit from final class "Base1" [misc]
qualifiers_final_decorator.py:56: error: Cannot override final attribute "method1" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:59: error: Cannot override final attribute "method2" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:63: error: Cannot override final attribute "method3" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:67: error: Cannot override final attribute "method4" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:80: error: Cannot override final attribute "method" (previously declared in base class "Base3") [misc]
qualifiers_final_decorator.py:84: error: @final should be applied only to overload implementation [misc]
qualifiers_final_decorator.py:94: error: Cannot override final attribute "method" (previously declared in base class "Base4") [misc]
qualifiers_final_decorator.py:118: error: Cannot override final attribute "method" (previously declared in base class "Base5_2") [misc]
qualifiers_final_decorator.py:118: error: Signature of "method" incompatible with supertype "Base5_2" [override]
qualifiers_final_decorator.py:118: note: Superclass:
qualifiers_final_decorator.py:118: note: def method(self, v: int) -> None
qualifiers_final_decorator.py:118: note: Subclass:
qualifiers_final_decorator.py:118: note: def method(self) -> None
qualifiers_final_decorator.py:125: error: @final cannot be used with non-method functions [misc]
qualifiers_final_decorator.py:63: error: Cannot override final attribute "method1" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:66: error: Cannot override final attribute "method2" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:70: error: Cannot override final attribute "method3" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:74: error: Cannot override final attribute "method4" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:85: error: Cannot override final attribute "method5" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:91: error: Cannot override final attribute "method" (previously declared in base class "Base3") [misc]
qualifiers_final_decorator.py:95: error: @final should be applied only to overload implementation [misc]
qualifiers_final_decorator.py:105: error: Cannot override final attribute "method" (previously declared in base class "Base4") [misc]
qualifiers_final_decorator.py:129: error: Cannot override final attribute "method" (previously declared in base class "Base5_2") [misc]
qualifiers_final_decorator.py:129: error: Signature of "method" incompatible with supertype "Base5_2" [override]
qualifiers_final_decorator.py:129: note: Superclass:
qualifiers_final_decorator.py:129: note: def method(self, v: int) -> None
qualifiers_final_decorator.py:129: note: Subclass:
qualifiers_final_decorator.py:129: note: def method(self) -> None
qualifiers_final_decorator.py:136: error: @final cannot be used with non-method functions [misc]
"""
conformance_automated = "Pass"
errors_diff = """
Expand Down
27 changes: 17 additions & 10 deletions conformance/results/pycroscope/qualifiers_final_decorator.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,22 @@
conformance_automated = "Pass"
conformant = "Partial"
notes = """
Reports an internal traceback for a valid `@final` property declaration.
"""
conformance_automated = "Fail"
errors_diff = """
Line 58: Unexpected errors ['./qualifiers_final_decorator.py:58:4: Traceback (most recent call last):']
"""
output = """
./qualifiers_final_decorator.py:21:15: Cannot inherit from final class [invalid_base]
./qualifiers_final_decorator.py:56:4: Cannot override final attribute method1 [incompatible_override]
./qualifiers_final_decorator.py:60:4: Cannot override final attribute method2 [incompatible_override]
./qualifiers_final_decorator.py:64:4: Cannot override final attribute method3 [incompatible_override]
./qualifiers_final_decorator.py:75:4: Cannot override final attribute method4 [incompatible_override]
./qualifiers_final_decorator.py:86:4: @final should be applied only to the overload implementation [invalid_final]
./qualifiers_final_decorator.py:89:4: Cannot override final attribute method [incompatible_override]
./qualifiers_final_decorator.py:102:4: Cannot override final attribute method [incompatible_override]
./qualifiers_final_decorator.py:118:4: Cannot override final attribute method [incompatible_override]
./qualifiers_final_decorator.py:126:0: @final is not allowed on non-method functions [invalid_final]
./qualifiers_final_decorator.py:58:4: Traceback (most recent call last):
./qualifiers_final_decorator.py:63:4: Cannot override final attribute method1 [incompatible_override]
./qualifiers_final_decorator.py:67:4: Cannot override final attribute method2 [incompatible_override]
./qualifiers_final_decorator.py:71:4: Cannot override final attribute method3 [incompatible_override]
./qualifiers_final_decorator.py:82:4: Cannot override final attribute method4 [incompatible_override]
./qualifiers_final_decorator.py:86:4: Cannot override final attribute method5 [incompatible_override]
./qualifiers_final_decorator.py:97:4: @final should be applied only to the overload implementation [invalid_final]
./qualifiers_final_decorator.py:100:4: Cannot override final attribute method [incompatible_override]
./qualifiers_final_decorator.py:113:4: Cannot override final attribute method [incompatible_override]
./qualifiers_final_decorator.py:129:4: Cannot override final attribute method [incompatible_override]
./qualifiers_final_decorator.py:137:0: @final is not allowed on non-method functions [invalid_final]
"""
19 changes: 10 additions & 9 deletions conformance/results/pyrefly/qualifiers_final_decorator.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@ errors_diff = """
"""
output = """
ERROR qualifiers_final_decorator.py:21:16-21: Cannot extend final class `Base1` [invalid-inheritance]
ERROR qualifiers_final_decorator.py:56:9-16: `method1` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:60:9-16: `method2` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:64:9-16: `method3` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:68:9-16: `method4` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:81:9-15: `method` is declared as final in parent class `Base3` [bad-override]
ERROR qualifiers_final_decorator.py:86:9-15: `@final` should only be applied to the implementation of an overloaded function. [invalid-overload]
ERROR qualifiers_final_decorator.py:95:9-15: `method` is declared as final in parent class `Base4` [bad-override]
ERROR qualifiers_final_decorator.py:118:9-15: `method` is declared as final in parent class `Base5_2` [bad-override]
WARN qualifiers_final_decorator.py:125:1-7: Decorator `@final` can only be used on methods. [invalid-decorator]
ERROR qualifiers_final_decorator.py:63:9-16: `method1` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:67:9-16: `method2` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:71:9-16: `method3` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:75:9-16: `method4` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:86:9-16: `method5` is declared as final in parent class `Base2` [bad-override]
ERROR qualifiers_final_decorator.py:92:9-15: `method` is declared as final in parent class `Base3` [bad-override]
ERROR qualifiers_final_decorator.py:97:9-15: `@final` should only be applied to the implementation of an overloaded function. [invalid-overload]
ERROR qualifiers_final_decorator.py:106:9-15: `method` is declared as final in parent class `Base4` [bad-override]
ERROR qualifiers_final_decorator.py:129:9-15: `method` is declared as final in parent class `Base5_2` [bad-override]
WARN qualifiers_final_decorator.py:136:1-7: Decorator `@final` can only be used on methods. [invalid-decorator]
"""
21 changes: 11 additions & 10 deletions conformance/results/pyright/qualifiers_final_decorator.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
conformant = "Pass"
output = """
qualifiers_final_decorator.py:21:16 - error: Base class "Base1" is marked final and cannot be subclassed (reportGeneralTypeIssues)
qualifiers_final_decorator.py:56:9 - error: Method "method1" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:60:9 - error: Method "method2" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:64:9 - error: Method "method3" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:75:9 - error: Method "method4" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:86:9 - error: @final decorator should be applied only to the implementation (reportInconsistentOverload)
qualifiers_final_decorator.py:89:9 - error: Method "method" cannot override final method defined in class "Base3" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:102:9 - error: Method "method" cannot override final method defined in class "Base4" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:118:9 - error: Method "method" cannot override final method defined in class "Base5_2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:118:9 - error: Method "method" overrides class "Base5_2" in an incompatible manner
qualifiers_final_decorator.py:63:9 - error: Method "method1" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:67:9 - error: Method "method2" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:71:9 - error: Method "method3" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:82:9 - error: Method "method4" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:86:9 - error: Method "method5" cannot override final method defined in class "Base2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:97:9 - error: @final decorator should be applied only to the implementation (reportInconsistentOverload)
qualifiers_final_decorator.py:100:9 - error: Method "method" cannot override final method defined in class "Base3" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:113:9 - error: Method "method" cannot override final method defined in class "Base4" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:129:9 - error: Method "method" cannot override final method defined in class "Base5_2" (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:129:9 - error: Method "method" overrides class "Base5_2" in an incompatible manner
  Positional parameter count mismatch; base method has 2, but override has 1
  Parameter 2 mismatch: base parameter "v" is keyword parameter, override parameter is position-only (reportIncompatibleMethodOverride)
qualifiers_final_decorator.py:126:5 - error: Function "func1" cannot be marked @final because it is not a method (reportGeneralTypeIssues)
qualifiers_final_decorator.py:137:5 - error: Function "func1" cannot be marked @final because it is not a method (reportGeneralTypeIssues)
"""
conformance_automated = "Pass"
errors_diff = """
Expand Down
11 changes: 8 additions & 3 deletions conformance/results/results.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 11 additions & 10 deletions conformance/results/ty/qualifiers_final_decorator.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@ errors_diff = """
"""
output = """
qualifiers_final_decorator.py:21:16: error[subclass-of-final-class] Class `Derived1` cannot inherit from final class `Base1`
qualifiers_final_decorator.py:56:9: error[override-of-final-method] Cannot override final member `method1` from superclass `Base2`
qualifiers_final_decorator.py:60:9: error[override-of-final-method] Cannot override final member `method2` from superclass `Base2`
qualifiers_final_decorator.py:64:9: error[override-of-final-method] Cannot override final member `method3` from superclass `Base2`
qualifiers_final_decorator.py:75:9: error[override-of-final-method] Cannot override final member `method4` from superclass `Base2`
qualifiers_final_decorator.py:86:9: error[invalid-overload] `@final` decorator should be applied only to the overload implementation
qualifiers_final_decorator.py:89:9: error[override-of-final-method] Cannot override final member `method` from superclass `Base3`
qualifiers_final_decorator.py:102:9: error[override-of-final-method] Cannot override final member `method` from superclass `Base4`
qualifiers_final_decorator.py:118:9: error[invalid-method-override] Invalid override of method `method`: Definition is incompatible with `Base5_2.method`
qualifiers_final_decorator.py:118:9: error[override-of-final-method] Cannot override final member `method` from superclass `Base5_2`
qualifiers_final_decorator.py:125:1: error[final-on-non-method] `@final` cannot be applied to non-method function `func1`
qualifiers_final_decorator.py:63:9: error[override-of-final-method] Cannot override final member `method1` from superclass `Base2`
qualifiers_final_decorator.py:67:9: error[override-of-final-method] Cannot override final member `method2` from superclass `Base2`
qualifiers_final_decorator.py:71:9: error[override-of-final-method] Cannot override final member `method3` from superclass `Base2`
qualifiers_final_decorator.py:82:9: error[override-of-final-method] Cannot override final member `method4` from superclass `Base2`
qualifiers_final_decorator.py:86:9: error[override-of-final-method] Cannot override final member `method5` from superclass `Base2`
qualifiers_final_decorator.py:97:9: error[invalid-overload] `@final` decorator should be applied only to the overload implementation
qualifiers_final_decorator.py:100:9: error[override-of-final-method] Cannot override final member `method` from superclass `Base3`
qualifiers_final_decorator.py:113:9: error[override-of-final-method] Cannot override final member `method` from superclass `Base4`
qualifiers_final_decorator.py:129:9: error[invalid-method-override] Invalid override of method `method`: Definition is incompatible with `Base5_2.method`
qualifiers_final_decorator.py:129:9: error[override-of-final-method] Cannot override final member `method` from superclass `Base5_2`
qualifiers_final_decorator.py:136:1: error[final-on-non-method] `@final` cannot be applied to non-method function `func1`
"""
29 changes: 15 additions & 14 deletions conformance/results/zuban/qualifiers_final_decorator.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,19 @@ errors_diff = """
"""
output = """
qualifiers_final_decorator.py:21: error: Cannot inherit from final class "Base1" [misc]
qualifiers_final_decorator.py:56: error: Cannot override final attribute "method1" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:59: error: Cannot override final attribute "method2" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:63: error: Cannot override final attribute "method3" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:67: error: Cannot override final attribute "method4" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:80: error: Cannot override final attribute "method" (previously declared in base class "Base3") [misc]
qualifiers_final_decorator.py:85: error: @final should be applied only to overload implementation [misc]
qualifiers_final_decorator.py:94: error: Cannot override final attribute "method" (previously declared in base class "Base4") [misc]
qualifiers_final_decorator.py:118: error: Cannot override final attribute "method" (previously declared in base class "Base5_2") [misc]
qualifiers_final_decorator.py:118: error: Signature of "method" incompatible with supertype "Base5_2" [override]
qualifiers_final_decorator.py:118: note: Superclass:
qualifiers_final_decorator.py:118: note: def method(self, v: int) -> None
qualifiers_final_decorator.py:118: note: Subclass:
qualifiers_final_decorator.py:118: note: def method(self) -> None
qualifiers_final_decorator.py:125: error: @final cannot be used with non-method functions [misc]
qualifiers_final_decorator.py:63: error: Cannot override final attribute "method1" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:66: error: Cannot override final attribute "method2" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:70: error: Cannot override final attribute "method3" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:74: error: Cannot override final attribute "method4" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:85: error: Cannot override final attribute "method5" (previously declared in base class "Base2") [misc]
qualifiers_final_decorator.py:91: error: Cannot override final attribute "method" (previously declared in base class "Base3") [misc]
qualifiers_final_decorator.py:96: error: @final should be applied only to overload implementation [misc]
qualifiers_final_decorator.py:105: error: Cannot override final attribute "method" (previously declared in base class "Base4") [misc]
qualifiers_final_decorator.py:129: error: Cannot override final attribute "method" (previously declared in base class "Base5_2") [misc]
qualifiers_final_decorator.py:129: error: Signature of "method" incompatible with supertype "Base5_2" [override]
qualifiers_final_decorator.py:129: note: Superclass:
qualifiers_final_decorator.py:129: note: def method(self, v: int) -> None
qualifiers_final_decorator.py:129: note: Subclass:
qualifiers_final_decorator.py:129: note: def method(self) -> None
qualifiers_final_decorator.py:136: error: @final cannot be used with non-method functions [misc]
"""
Loading