-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[tzdata] Add package stubs #14997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tzdata] Add package stubs #14997
Conversation
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Thank you! But given that |
|
I’m split on this, if we were to add them we would be further straying from the idea of „data-only”. |
|
It might be worth opening issue to gather Paul Ganssle’s input on this. Until then, it seems reasonable to keep the current types in typeshed, considering Paul might not be available in the near term. |
srittau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
FYI I messaged Paul. |
|
FTR Paul also doesn’t support moving them to the package itself, they will be staying here. |
tzdata is a first-party package and generally data-only, except for these two constants (and we don't plan on adding any more).