Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Nov 8, 2025

tzdata is a first-party package and generally data-only, except for these two constants (and we don't plan on adding any more).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@donBarbos
Copy link
Contributor

Thank you! But given that tzdata is well supported, and adding its own stubs or type annotations to the library itself is the preferred method of distributing type information, I suggest the package itself distribute these types (along with the py.typed).
What do you think about?

@StanFromIreland
Copy link
Member Author

I’m split on this, if we were to add them we would be further straying from the idea of „data-only”.

@donBarbos
Copy link
Contributor

It might be worth opening issue to gather Paul Ganssle’s input on this. Until then, it seems reasonable to keep the current types in typeshed, considering Paul might not be available in the near term.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 4239e94 into python:main Nov 10, 2025
48 checks passed
@StanFromIreland StanFromIreland deleted the tzdata branch November 10, 2025 15:55
@StanFromIreland
Copy link
Member Author

FYI I messaged Paul.

@StanFromIreland
Copy link
Member Author

FTR Paul also doesn’t support moving them to the package itself, they will be staying here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants