Infra: update linting/formatting for non-peps/ dirs - #5121
Open
hugovk wants to merge 5 commits into
Open
Conversation
hugovk
requested review from
a team,
AA-Turner and
CAM-Gerlach
as code owners
September 9, 2026 21:36
JelleZijlstra
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it confusing we run Black on some dirs, and the Ruff formatter on others, and no formatter on others.
Similarly, we Ruff lint some dirs, and not others.
Let's pick just one formatter, and apply to all directories (except
peps/). I picked Black, but don't mind using Ruff instead.And let's also lint all dirs (except
peps/).Finally, combine the two
.ruff.tomlfiles into a top-levelpyproject.toml, and add a couple of lint rules.