Repository navigation
Conversation
u32 is an unsigned 32-bit integer. The implementation mostly follows u16 (#22368). Major differences: - Boxing uses PyLong_FromUnsignedLong. - On 32-bit platforms a u32 may not fit in a short tagged int, so converting to int checks the range and calls CPyTagged_FromUInt32 for large values, and converting from a long int uses CPyLong_AsUInt32. Work on mypyc/mypyc#1226.
This comment has been minimized.
This comment has been minimized.
p-sawicki
reviewed
Nov 5, 2026
Comment on lines
+473
to
+474
| if (x < 0x40000000) | ||
| return x; |
Collaborator
There was a problem hiding this comment.
the digits are at most 30 bits so the check is redundant. we could return immediately to match CPyLong_AsInt32.
Comment on lines
+484
to
+485
| if (x < 65536) | ||
| return x; |
A single digit is at most 30 bits, so it always fits in uint32_t.
p-sawicki
approved these changes
Nov 5, 2026
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
u32 is an unsigned 32-bit integer. The implementation mostly follows u16 (#22368).
Major differences:
Work on mypyc/mypyc#1226.