Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions mypy/checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -3181,12 +3181,10 @@ def is_noop_for_reachability(self, s: Statement) -> bool:
return True
elif isinstance(s, ReturnStmt) and is_literal_not_implemented(s.expr):
return True
elif isinstance(s, (RaiseStmt, PassStmt)):
elif isinstance(s, RaiseStmt):
return True
elif isinstance(s, ExpressionStmt):
if isinstance(s.expr, EllipsisExpr):
return True
elif isinstance(s.expr, CallExpr):
if isinstance(s.expr, CallExpr):
with self.expr_checker.msg.filter_errors(filter_revealed_type=True):
typ = get_proper_type(
self.expr_checker.accept(
Expand Down
10 changes: 10 additions & 0 deletions test-data/unit/check-unreachable-code.test
Original file line number Diff line number Diff line change
Expand Up @@ -1637,7 +1637,17 @@ class C:
return C()
else:
return NotImplemented
[builtins fixtures/isinstance.pyi]

[case testPassAndEllipsisUnreachable]
# flags: --warn-unreachable
def f() -> None:
return
pass # E: Statement is unreachable

def g() -> None:
return
... # E: Statement is unreachable
[builtins fixtures/isinstance.pyi]

[case testUnreachableStatementPrettyHighlighting]
Expand Down