Skip to content

gh-1359: Document follow-up for out-of-scope review suggestions #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
badrisatyam1-ctrl wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-1359: Document follow-up for out-of-scope review suggestions #1940

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a4e73d
gh-1359: Document review follow-up tracking
badrisatyam1-ctrl Oct 27, 2026
bc02798
Merge branch 'main' into codex/follow-up-review-comments
badrisatyam1-ctrl Oct 28, 2026
ceb2177
Merge branch 'main' into codex/follow-up-review-comments
badrisatyam1-ctrl Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions getting-started/pull-request-lifecycle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,13 @@ back to them for changes). It is then expected that you update your
pull request to address these comments, and the review process will
thus iterate until a satisfactory solution has emerged.

Sometimes a review identifies a concrete improvement that is outside the scope
of the current pull request. Discuss who will follow up on it. Once someone
agrees to take responsibility for tracking it, create an issue or pull request
that links to the original review comment. The follow-up issue provides context
and a reminder; creating it does not by itself commit its author to implement
the change.

.. _how-to-review-a-pull-request:

How to review a pull request
Expand Down