Skip to content

bpo-42643: Add support for HTTP range requests - #24228

Open
DavidBord wants to merge 2 commits into
python:mainfrom
DavidBord:http-range-requests-bpo-42643
Open

bpo-42643: Add support for HTTP range requests#24228
DavidBord wants to merge 2 commits into
python:mainfrom
DavidBord:http-range-requests-bpo-42643

Conversation

@DavidBord

@DavidBord DavidBord commented Jan 16, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Feb 16, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 16, 2021
@roolebo

roolebo commented Feb 20, 2021

Copy link
Copy Markdown

@DavidBord Thanks! I think built-in range support is going to be helpful

@stokito

stokito commented Feb 20, 2021

Copy link
Copy Markdown

It’s needed to resume downloads and this may significantly reduce load in some cases. That’s why even minimal busybox httpd has a support of Range requests

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 21, 2021
@github-actions

github-actions Bot commented Mar 23, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 23, 2021
@chrisroat

chrisroat commented Jun 25, 2021

Copy link
Copy Markdown

This is a most welcome update. Thank you @DavidBord

@imba-tjd

imba-tjd commented Feb 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Personally I think it's fundamental to support Range: bytes=<range-start>- i.e. no <range-end>.

Others I think are OK.

I'm using a modified version of this patch in my program https://github.com/imba-tjd/qrsend. I will share info when I found defects.

imba-tjd
imba-tjd suggested changes Apr 25, 2022
View reviewed changes
Comment thread Lib/http/server.py Outdated
shutil.copyfileobj(source, outputfile)
if start_byte is not None and end_byte is not None:
source.seek(start_byte)
outputfile.write(source.read(end_byte))

@imba-tjd imba-tjd Apr 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fatal error. When you use 2-5, the start_byte is 2 and end_byte is 5. Then you read(5).
The correct behavior is read(4), which is end_byte-start_byte+1. Though I won't suggest whether putting +1 here or previous place.

More importantly, read() will load all data into memory in a row before start writing. This has serious performance issue when resuming large file. I tried source.truncate() but it turns out an io.UnsupportedOperation.

Besides Content-Length needs changing too. So that new testing is recommended to be added, too.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 3, 2022
@AraHaan AraHaan mannequin mentioned this pull request Mar 3, 2023
Open
@muxator

muxator commented Apr 3, 2026

Copy link
Copy Markdown

Is there a way to help reviewing this PR? I'd like to help.

@imba-tjd

imba-tjd commented Apr 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Is there a way to help reviewing this PR? I'd like to help.

There was another PR which was detailed discussed. However it seems to be deleted. Maybe it will be recoverd.

This PR is poorly implemented and can be closed IMO.

@GalaxySnail

GalaxySnail commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

You can use git fetch origin pull/118949/head:pr/118949 to get the code in #118949. The latest commit on this branch is 580aa14. And the latest archive on the Wayback Machine is https://web.archive.org/web/20250925083524/https://github.com/python/cpython/pull/118949.

@github-actions

github-actions Bot commented May 10, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 10, 2026
@DavidBord
DavidBord force-pushed the http-range-requests-bpo-42643 branch from 87935c0 to a89f588 Compare July 24, 2026 13:33
@DavidBord
DavidBord requested a review from AA-Turner as a code owner July 24, 2026 13:33
@DavidBord

DavidBord commented Jul 24, 2026

Copy link
Copy Markdown
Author

I went through the review feedback on this PR.
I also went over GH-118949 and brought over the pieces that were valuable here.

@read-the-docs-community

read-the-docs-community Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33745551 | 📁 Comparing 1aedfad against main (a400767)

  🔍 Preview build  

3 files changed
± library/http.server.html
± whatsnew/3.16.html
± whatsnew/changelog.html

@DavidBord
DavidBord force-pushed the http-range-requests-bpo-42643 branch from cd2dfba to 1aedfad Compare July 24, 2026 15:10
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
3 more reviewers
@imba-tjd imba-tjd imba-tjd requested changes
@stokito stokito stokito approved these changes
@adhikariabhiram adhikariabhiram adhikariabhiram approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.