Skip to content

gh-156376: Fix test_environ_path_cwd when NoDefaultCurrentDirectoryInExePath is set #161277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArtyomSimitian wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-156376: Fix test_environ_path_cwd when NoDefaultCurrentDirectoryInExePath is set #161277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbf82ce
gh-156376: Fix test_environ_path_cwd when NoDefaultCurrentDirectoryIn…
ArtyomSimitian Nov 3, 2026
df8a234
Add missing final newline to NEWS entry
ArtyomSimitian Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/test/test_shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2729,7 +2729,9 @@ def test_environ_path_cwd(self):
self.assertIsNone(rv)

# look in current directory
with os_helper.change_cwd(self.dir):
with os_helper.change_cwd(self.dir), \
unittest.mock.patch('shutil._win_path_needs_curdir',
return_value=True):
rv = shutil.which(self.file)
self.assertEqual(rv, expected_cwd)

Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Tests/2026-11-03-22-45-00.gh-issue-156376.Wq7rKe.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix ``test_shutil.test_environ_path_cwd`` on Windows, which relied on the
user's ``NoDefaultCurrentDirectoryInExePath`` environment setting and was
therefore non-deterministic.
Loading