Repository navigation
gh-159184: Do not intern NaN constants on the free-threaded build - #161276
Merged
Merged
Conversation
compare_constants() matches floats by bits, but hash_const() uses the object hash, which for a NaN depends on its address, so each NaN loaded by marshal.loads() added an immortal entry to the constants table. Hashing the bits would merge NaNs and shrink frozensets, so leave them out of the table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
!buildbot Refleaks NoGIL|NoGIL Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @cmaloney for commit aba373c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F161276%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
gpshead
approved these changes
Nov 4, 2026
gpshead
added
needs backport to 3.14
|
GH-161286 is a backport of this pull request to the 3.14 branch. |
|
GH-161287 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare_constants() matches floats by bits, but hash_const() uses the object hash, which for a NaN depends on its address, so each NaN loaded by marshal.loads() added an immortal entry to the constants table. Hashing the bits would merge NaNs and shrink frozensets, so leave them out of the table.
marshal.dumps()raisesTypeErrorfor a set containing several complex NaNs #159184