Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Lib/smtplib.py
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,11 @@ def send_message(self, msg, from_addr=None, to_addrs=None,

def close(self):
"""Close the connection to the SMTP server."""
# A new EHLO is required after reconnecting with connect()
self.ehlo_resp = self.helo_resp = None
self.esmtp_features = {}
self.does_esmtp = False

try:
file = self.file
self.file = None
Expand All @@ -1003,10 +1008,6 @@ def close(self):
def quit(self):
"""Terminate the SMTP session."""
res = self.docmd("quit")
# A new EHLO is required after reconnecting with connect()
self.ehlo_resp = self.helo_resp = None
self.esmtp_features = {}
self.does_esmtp = False
self.close()
return res

Expand Down
34 changes: 34 additions & 0 deletions Lib/test/test_smtplib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1265,6 +1265,40 @@ def test_quit_resets_greeting(self):
self.assertIn('size', smtp.esmtp_features)
smtp.quit()

def test_close_resets_greeting(self):
smtp = smtplib.SMTP(HOST, self.port,
local_hostname='localhost',
timeout=support.LOOPBACK_TIMEOUT)
code, _ = smtp.ehlo()
self.assertEqual(code, 250)
self.assertIn('size', smtp.esmtp_features)
smtp.close()
self.assertNotIn('size', smtp.esmtp_features)
smtp.connect(HOST, self.port)
self.assertNotIn('size', smtp.esmtp_features)
smtp.ehlo_or_helo_if_needed()
self.assertIn('size', smtp.esmtp_features)
smtp.quit()

def test_with_statement_resets_greeting(self):
with smtplib.SMTP(HOST, self.port,
local_hostname='localhost',
timeout=support.LOOPBACK_TIMEOUT) as smtp:
smtp.ehlo()
self.assertIn('size', smtp.esmtp_features)

self.assertNotIn('size', smtp.esmtp_features)

msg = EmailMessage()
msg['From'] = 'test_from'
msg['To'] = 'test_to'
msg['Subject'] = 'test_subject'

smtp.connect(HOST, self.port)
smtp.send_message(msg)
self.assertIn('size', smtp.esmtp_features)
smtp.quit()

def test_with_statement(self):
with smtplib.SMTP(HOST, self.port) as smtp:
code, message = smtp.noop()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix :meth:`!smtplib.SMTP.close` not resetting the EHLO state, so an
:class:`!SMTP` object reconnected with :meth:`~smtplib.SMTP.connect` sent
``MAIL FROM`` without a new EHLO.
Loading