Repository navigation
gh-93821: Keep asyncio proactor servers accepting after a connection reset - #161238
Merged
Merged
Conversation
…ction reset Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
asvetlov
marked this pull request as ready for review
November 3, 2026 16:03
asvetlov
requested review from
1st1,
kumaraditya303 and
willingc
as code owners
November 3, 2026 16:03
|
Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161308 is a backport of this pull request to the 3.15 branch. |
|
GH-161309 is a backport of this pull request to the 3.14 branch. |
This was referenced Nov 4, 2026
|
Contributor
Author
|
The failure is not related to the change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a client resets its connection while it waits in the listen queue,
AcceptExfails withERROR_NETNAME_DELETED(WinError 64). The proactor serving loop then closes the listening socket, and the server stops accepting connections.This PR turns that error into
ConnectionResetErrorand closes the failed accept socket. The serving loop then keeps accepting onConnectionResetError/ConnectionAbortedError, as the selector loop does.test_accept_connection_resetreproduces the bug on Windows: without the fix it failed 3 runs out of 3, and with it the test passed 10 out of 10.This supersedes gh-124032 and gh-124779.
🤖 Generated with Claude Code