Skip to content

gh-160736: Fix test_distrusted_spki on AWS-LC builds #161213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
torben-hansen wants to merge 1 commit into from
Closed

gh-160736: Fix test_distrusted_spki on AWS-LC builds #161213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2801,8 +2801,14 @@
with self.assertRaises(ssl.SSLCertVerificationError) as cm:
connected_bio_pair(client_context, server_context,
DISTRUSTED_SPKI_HOSTNAME)
# X509_V_ERR_CERT_REJECTED
self.assertEqual(cm.exception.verify_code, 28)
if IS_AWS_LC:
# gh-160736: AWS-LC has its own SPKI denylist. It fails the
# chain before _ssl's verify callback sees the certificate,
# so the library's error is kept: X509_V_ERR_CERT_REVOKED.
self.assertEqual(cm.exception.verify_code, 23)

Check failure on line 2808 in Lib/test/test_ssl.py

View workflow job for this annotation

GitHub Actions / Ubuntu SSL tests (ubuntu-26.04, aws-lc, 5.10.0)

test_distrusted_spki (test.test_ssl.SSLObjectTests.test_distrusted_spki) 

AssertionError: 28 != 23
else:
# Rejected by _ssl's verify callback: X509_V_ERR_CERT_REJECTED
self.assertEqual(cm.exception.verify_code, 28)

def test_sni_callback_context_released_and_callback_raises(self):
# Variant of the test below without a HelloRetryRequest: the callback
Expand Down
Loading