Repository navigation
gh-95498: Document open() behavior with file descriptors - #161193
Open
raihanshiras wants to merge 1 commit into
Open
raihanshiras wants to merge 1 commit into
raihanshiras wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-95498
Document the behavior of
open()when passed an existing file descriptor.When an existing file descriptor is passed to
open(), its underlying access mode is not changed. The caller is responsible for ensuring that the file descriptor is compatible with the requested mode.This is a resubmission of the documentation change from #159324. The earlier PR was closed while the PSF Individual Contributor Agreement was unsigned; the CLA has now been signed for the commit author email, and the CLA bot confirms all commit authors have signed.
Tests
git diff --checkpassed.