Repository navigation
gh-161078: Correct unstable C API PEP references - #161158
TheLouisMahdi wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Documentation build overview
49 files changed ·
|
CAM-Gerlach
left a comment
There was a problem hiding this comment.
The change itself is correct, except that the existing ref target label should be moved to the correct location, rather than simply replaced, to avoid breaking existing users. Please apply it by clicking the "Apply suggestion" button, or via the Files pane.
It's not backportable all the way to the original version, but the What's New is often accessed from newer versions and remains present perpetually, so I don't think this error has to and don't see the harm there.
I am a bit concerned about how much genuine human input was present here, given the comments on # --please respond, as a human, not an agent, confirming you've personally taken responsibly for this. However, given it is a trivial, correct and not substantial enough to be copyrightable change, I'm not sure its enough of an issue in practice to block this on its own.
| (Contributed by Petr Viktorin in :gh:`101101`.) | ||
|
|
||
| * :pep:`697`: Add an API for extending types whose instance memory layout is |
There was a problem hiding this comment.
| (Contributed by Petr Viktorin in :gh:`101101`.) | |
| .. _whatsnew312-pep697: | |
| * :pep:`697`: Add an API for extending types whose instance memory layout is |
Move the existing ref target label to the correct place, and avoid breaking anyone currently relying on it.
There was a problem hiding this comment.
Suggested change
(Contributed by Petr Viktorin in :gh:101101.)
.. _whatsnew312-pep697:
- :pep:
697: Add an API for extending types whose instance memory layout is
Unable to apply suggestions when viewing a specific commit range.
Move the existing ref target label to the correct place, and avoid breaking anyone currently relying on it.
Thanks for the detailed review. You're right about the existing reference target.
I've updated the patch to preserve whatsnew312-pep697 at the actual PEP 697 section while keeping whatsnew312-pep689 at the Unstable C API entry. This should preserve existing links while correcting the reference.
Regarding your concern about human involvement, I used AI assistance as disclosed in the PR description. I understand the change, have reviewed the patch, and take responsibility for the contribution.
Thanks again for pointing this out.
Summary
Correct the Unstable C API tier references from PEP 697 to PEP 689 in
Doc/whatsnew/3.12.rst, including the associated internal label.The separate PEP 697 entry remains unchanged.
Closes #161078.
Testing
Doc/pylock.toml.git diff --check: passed.Sol 6.1 High was used to assist with preparing the change and validation.