Repository navigation
gh-161092: Require an octal mode in the uu codec "begin" line - #161093
Merged
Merged
Conversation
Skip lines starting with "begin" that are not followed by an octal mode, as email.message._decode_uu() does, instead of taking them as the header.
gpshead
marked this pull request as ready for review
November 1, 2026 17:46
gpshead
enabled auto-merge (squash)
November 1, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only accept a
beginline followed by an octal mode as the uuencode header in theuucodec's decoder, and skip other lines starting withbeginas leading text. This is the ruleemail.message._decode_uu()uses; the filename stays optional, so headers likebegin 666keep working, unlike the removeduu.decode()which required one. Output ofuu_encode()is unaffected. Deprecation of the codec is still undecided in gh-92613.Fixes #161092
ANT-2026-XQTI5P71
uucodec decoder treats any line starting with "begin" as the header #161092