Repository navigation
gh-161090: Reject a leading delimiter in the punycode decoder - #161091
Merged
Merged
Conversation
RFC 3492 section 6.2 only consumes the delimiter when at least one basic code point precedes it. A leading "-" is now an invalid digit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only treat a
-as the delimiter between the basic and extended parts if at least one basic code point precedes it, as RFC 3492 section 6.2 (and the reference decoder in its appendix C) requires. A leading-is now left in the extended part, where it hits the existing invalid-digit error, sob"-80a1acny"raisesUnicodeDecodeErrorat offset 0 (or decodes to""witherrors="ignore"). This makes decoding stricter, so it is meant for main only; no encoder produces such input.Fixes #161090
ANT-2026-0IEDOPPK
punycodecodec accepts a delimiter with no basic code points before it #161090