Repository navigation
Conversation
flush() re-enabled tell() while the decoder snapshot was stale from next(), so tell() returned a wrong position. seek() now re-enables tell() itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextIOWrapper.__next__()stops updating the decoder snapshot thattell()uses, butflush()re-enabledtell()unconditionally, sotell()returned a wrong position (and failed an assertion in debug builds whennext()was the first read).flush()now re-enablestell()only when there is neither a snapshot nor pending decoded text, which keepstell()working after awrite()or aread()to EOF that followsnext().seek(), which relied onflush()for this, now re-enables it itself, in both the C and Python implementations. The position cannot be recovered without the snapshot, sotell()raises the sameOSErrorit raises without theflush()call; lettingnext()keeptell()working is gh-81217.Fixes #161055
TextIOWrapper.tell()returns a wrong position afternext()andflush()#161055