Repository navigation
Conversation
… seek() Clamp the bytes-per-character start guess in tell() to the size of the decoder snapshot instead of only asserting it.
gpshead
added
needs backport to 3.14
gpshead
added
stdlib
gpshead
marked this pull request as ready for review
November 1, 2026 02:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clamp the start guess in
TextIOWrapper.tell()to the size of the decoder snapshot instead of only asserting it, in both the C and_pyioimplementations. The guess is only the starting point of the search that follows, so the returned cookies do not change.seek()still keeps the bytes-per-character ratio of the previous chunk; with the clamp that only affects how quickly the search converges, so recomputing it is left out to keep the backport small.Fixes #161053
ANT-2026-VCLYAYC1
TextIOWrapper.tell()reads past the decoder snapshot afterseek()#161053