Repository navigation
Conversation
…inidom Since pythongh-44376, _fixup_namespaces() adds xmlns="" to an element in no namespace under a default namespace. When the element declares the default namespace itself, as one built with createElement() and setAttribute("xmlns", ...) does, its own xmlns attribute was written too, so the output was not well-formed. Do not add the undeclaration if the element already has an xmlns attribute. The default namespace is still treated as undeclared for its children, so they are written as before.
Contributor
Author
|
@serhiy-storchaka, could you take a look when you have a moment? It fixes a regression from GH-156666. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_fixup_namespaces()no longer addsxmlns=""to an element in no namespace that already has its ownxmlnsattribute. The default namespace is still treated as undeclared for the element's children, so they are written as before.xml.dom.minidomwrites a duplicatexmlnsattribute #158208