gh-157227: _remote_debugging: Validate lists and tuples in write_sample - #157228
Open
maurycy wants to merge 2 commits into
Open
gh-157227: _remote_debugging: Validate lists and tuples in write_sample#157228maurycy wants to merge 2 commits into
_remote_debugging: Validate lists and tuples in write_sample#157228maurycy wants to merge 2 commits into
Conversation
maurycy
commented
Sep 9, 2026
| } \ | ||
| } while (0) | ||
|
|
||
| #define CHECK_TUPLE_ITEMS(obj, n) do { \ |
Contributor
Author
There was a problem hiding this comment.
Truth be told, we reinvent similar check over and over:
cpython/Objects/memoryobject.c
Lines 217 to 222 in 9a75080
Lines 26 to 33 in 9a75080
Sometimes without a macro:
cpython/Modules/_io/stringio.c
Lines 922 to 930 in 9a75080
Lines 450 to 465 in 9a75080
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #157227 for more details
Basically,
BinaryWriter.write_sample()only checks whetherstack_framesis a list, and doesPyList_GET_ITEM()/PyStructSequence_GET_ITEM()all the way. The PR adds a check for these containers.Now it's graceful:
instead of
segmentation fault.Closes #157227
_remote_debugging:BinaryWriter.write_sample()trivial segfault #157227