gh-157210: Attach a combining mark in the last curses Textbox cell - #157211
Open
fedonman wants to merge 1 commit into
Open
gh-157210: Attach a combining mark in the last curses Textbox cell#157211fedonman wants to merge 1 commit into
fedonman wants to merge 1 commit into
Conversation
The lower-right cell is written with insch(), which gives a lone combining mark a cell of its own and shifts the rest of the line right, so the character the mark belongs to was pushed off the window edge and lost. Merge the mark into the cell that is already there instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lower-right cell of a
Textboxis written withinsch(), which gave a lone combining mark a cell of its own and pushed the character it belongs to off the window edge. The mark is now merged into the cell that is already there.No
Misc/NEWS.dentry: a combining mark reaches that cell only through the string keystroke path added for 3.16, which has not been released.Textbox's last cell loses the base character #157210