gh-102572: Fix KeyboardInterrupt/SystemExit in TaskGroup child task crashing the event loop - #154761
Draft
kumaraditya303 wants to merge 1 commit into
Draft
gh-102572: Fix KeyboardInterrupt/SystemExit in TaskGroup child task crashing the event loop#154761kumaraditya303 wants to merge 1 commit into
kumaraditya303 wants to merge 1 commit into
Conversation
…ng the event loop A KeyboardInterrupt or SystemExit raised by a task in a TaskGroup was both set as the task's exception and re-raised into the event loop, stopping it before the group could re-raise the exception in the parent task as documented. Task now only re-raises KeyboardInterrupt/SystemExit into the event loop when the private flag Task._reraise_base_exceptions is true (the default); TaskGroup disables it for its child tasks since it delivers the exception to the parent task itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A KeyboardInterrupt or SystemExit raised by a task in a TaskGroup was both set as the task's exception and re-raised into the event loop, stopping it before the group could re-raise the exception in the parent task as documented.
Task now only re-raises KeyboardInterrupt/SystemExit into the event loop when the private flag Task._reraise_base_exceptions is true (the default); TaskGroup disables it for its child tasks since it delivers the exception to the parent task itself.
KeyboardInterruptinTaskGrouptask propagates to event loop scheduler #102572