gh-154730: Add timeout in PyREPL to distinguish between bare Esc and multibyte escape sequence#154731
Draft
tanloong wants to merge 4 commits into
Draft
gh-154730: Add timeout in PyREPL to distinguish between bare Esc and multibyte escape sequence#154731tanloong wants to merge 4 commits into
Esc and multibyte escape sequence#154731tanloong wants to merge 4 commits into
Conversation
Esc and multibyte escape sequenceEsc and multibyte escape sequence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a timeout to disambiguate bare Esc from the start of a longer escape sequence.
pending()toBaseEventQueue: returnsTruewhen the queue has consumed a prefix (e.g.,\x1b) but is still waiting for more bytes.flush()toBaseEventQueue: finalises a pending prefix as a standalone key (emits \x1b and re-feeds any remaining buffered bytes).esc_timeoutparameter toBaseEventQueue(default 0.1 seconds; override viaPYREPL_ESC_TIMEOUTenv var).In both
unix_console.get_event()andwindows_console.get_event(), whenevent_queue.pending()isTrue, the next read blocks only foresc_timeoutseconds. If the timeout expires, callflush()and deliver the standaloneEscevent.