gh-151162: Increase test coverage for string formatting - #151161
gh-151162: Increase test coverage for string formatting#151161manoj-marimuthu wants to merge 1 commit into
Conversation
| @@ -1557,7 +1557,8 @@ def __str__(self): | |||
| self.assertEqual('%F' % NAN, 'NAN') | |||
| self.assertEqual('%f' % INF, 'inf') | |||
| self.assertEqual('%F' % INF, 'INF') | |||
|
|
|||
| self.assertEqual('%f' % -INF, '-inf') | |||
There was a problem hiding this comment.
This is already covered in test_float.RoundTestCase.test_format_specials, and I don't think the second case is particularly special here.
There was a problem hiding this comment.
Thanks for taking the time to inform. Will close it.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
In
Lib/test/test_str.py, string formatting is tested for nan and inf but not for -inf. -inf could be the most important among them (since we have to check if '-' formats correctly). The following PR adds 2 test cases for -inf with %f and %F.Existing:
Added: