Skip to content

gh-149835: _destinsrc to use realpath instead of abspath#149986

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-_destinsrc-to-use-realpath-instead-of-abspath
Jun 6, 2026
Merged

gh-149835: _destinsrc to use realpath instead of abspath#149986
serhiy-storchaka merged 2 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-_destinsrc-to-use-realpath-instead-of-abspath

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented May 18, 2026 •
edited by bedevere-app Bot
Loading

@StanFromIreland StanFromIreland changed the title fix: _destinsrc to use realpath instead of abspath gh-149835: _destinsrc to use realpath instead of abspath May 18, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 18, 2026
Closed
@StanFromIreland
Copy link
Copy Markdown
Member

StanFromIreland commented May 18, 2026

Can you please pre-pend the issue number to the title in the future.

@KowalskiThomas
Copy link
Copy Markdown
Contributor Author

KowalskiThomas commented May 18, 2026

@StanFromIreland oh yeah right, I usually do but I forgot on this one 😅

@KowalskiThomas KowalskiThomas marked this pull request as ready for review May 18, 2026 15:49
@KowalskiThomas KowalskiThomas requested a review from giampaolo as a code owner May 18, 2026 15:49
serhiy-storchaka
serhiy-storchaka approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 29, 2026
@serhiy-storchaka serhiy-storchaka merged commit fab449b into python:main Jun 6, 2026
64 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Jun 6, 2026

Thanks @KowalskiThomas for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 6, 2026

GH-151009 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 6, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 6, 2026

GH-151010 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 6, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 6, 2026

GH-151011 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 6, 2026
serhiy-storchaka pushed a commit that referenced this pull request Jun 6, 2026
@miss-islington @KowalskiThomas
[3.13] gh-149835: Use realpath() instead of abspath() in shutil.move() (
73f9188 
GH-149986) (GH-151011)

(cherry picked from commit fab449b)

Co-authored-by: Thomas Kowalski <thom.kowa@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 6, 2026
@miss-islington @KowalskiThomas
[3.15] gh-149835: Use realpath() instead of abspath() in shutil.move() (
0a2e7af 
GH-149986) (GH-151009)

(cherry picked from commit fab449b)

Co-authored-by: Thomas Kowalski <thom.kowa@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 6, 2026
@miss-islington @KowalskiThomas
[3.14] gh-149835: Use realpath() instead of abspath() in shutil.move() (
a5ac721 
GH-149986) (GH-151010)

(cherry picked from commit fab449b)

Co-authored-by: Thomas Kowalski <thom.kowa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@giampaolo giampaolo Awaiting requested review from giampaolo giampaolo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

shutil.move can move the dir into itself (with a symlink)

3 participants

@KowalskiThomas @StanFromIreland @serhiy-storchaka