gh-149891: Add more encoding aliases#149892
Open
serhiy-storchaka wants to merge 2 commits into
Open
Conversation
Support all aliases officially registered in IANA. New names: Extended_UNIX_Code_Packed_Format_for_Japanese, KSC_5601, KS_C_5601-1989, iso-ir-149, GB_2312-80, windows-936, mac, CCSID00858, CCSID01140, and a number of "cs"-prefixed names. Fix csHPRoman8, which was not normalized.
…JUIGB.rst Co-authored-by: Stan Ulbrych <stan@python.org>
malemburg
requested changes
Jun 4, 2026
| # euc_jp codec | ||
| 'cseucpkdfmtjapanese' : 'euc_jp', | ||
| 'eucjp' : 'euc_jp', | ||
| 'extended_unix_code_packed_format_for_japanese' : 'euc_jp', |
Member
There was a problem hiding this comment.
Where did you find such a long encoding name ?
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Looking at the IANA page at https://www.iana.org/assignments/character-sets/character-sets.xhtml this does not appear to be an encoding name actually used in practice, but just an explanation of what "EUC-JP" stands for.
Save to remove, I think.
| 'euckr' : 'euc_kr', | ||
| 'iso_ir_149' : 'euc_kr', | ||
| 'korean' : 'euc_kr', | ||
| 'ks_c_5601_1987' : 'euc_kr', |
| 'cseuckr' : 'euc_kr', | ||
| 'csksc56011987' : 'euc_kr', | ||
| 'euckr' : 'euc_kr', | ||
| 'iso_ir_149' : 'euc_kr', |
| 'ks_c_5601_1987' : 'euc_kr', | ||
| 'ksc_5601' : 'euc_kr', | ||
| 'ksx1001' : 'euc_kr', | ||
| 'ks_x_1001' : 'euc_kr', |
Member
There was a problem hiding this comment.
See #62825
Most of these aliases should really go to cp949
|
When you're done making the requested changes, leave the comment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support all aliases officially registered in IANA.
New names: Extended_UNIX_Code_Packed_Format_for_Japanese, KSC_5601, KS_C_5601-1989, iso-ir-149, GB_2312-80, windows-936, mac, CCSID00858, CCSID01140, and a number of "cs"-prefixed names.
Fix csHPRoman8, which was not normalized.